[MBL-3164] Update the ppo card id to only be based on the project id#2820
Open
[MBL-3164] Update the ppo card id to only be based on the project id#2820
Conversation
amy-at-kickstarter
approved these changes
Mar 31, 2026
Contributor
amy-at-kickstarter
left a comment
There was a problem hiding this comment.
LGTM!
My one thought is we might want to add an assertion somewhere that logs if we ever get duplicate projects in this list. It feels impossible, but better safe than sorry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📲 What
Update the PPO card identifier to be equal to the project id, instead of also being based on the tier type and actions.
🤔 Why
I did some testing and this doesn't make a difference in most cases. But I think it'll make PPO actions a little better in the edge case where a card tier type changes, but the cards position in the list doesn't change. I wasn't able to find this edge case in any of my test accounts, but it could theoretically make the auto refresh better for some users.
Also, now that we've decided we'll have at most one card per project id, this change makes the identifier more intuitive for any future work in this space.
👀 See
Jira
✅ Acceptance criteria
⏰ TODO