-
Notifications
You must be signed in to change notification settings - Fork 16
Save more provenance information #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+181
−38
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
18d23ba
Take a stab at saving version info
ac6cf4c
Improve get_app_version README
c272bee
Add typings for importlib_metadata
8d25cfa
Add tests for added provenance
b2f34cf
Make version a SnakeBidsApp attribute
e285826
Pin importlib_metadata
b263e54
Make tested snakebids version more robust
d19c80f
Add draft warning if version can't be found
03c2c4c
Merge branch 'main' into provenance
f08dee1
Make version not found warning terser
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| def version(distribution_name: str) -> str: | ||
| """Get the version string for the named package. | ||
|
|
||
| :param distribution_name: The name of the distribution package to query. | ||
| :return: The version string for the package as defined in the package's | ||
| "Version" metadata key. | ||
| """ | ||
| ... | ||
|
|
||
| class PackageNotFoundError(ModuleNotFoundError): | ||
| """The package was not found.""" | ||
|
|
||
| def __str__(self) -> str: ... | ||
| @property | ||
| def name(self) -> str: ... |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.