Skip to content

build: add missing postcss-import dependency#744

Open
ParthMozarkar wants to merge 1 commit into
kgateway-dev:mainfrom
ParthMozarkar:fix/missing-dependency
Open

build: add missing postcss-import dependency#744
ParthMozarkar wants to merge 1 commit into
kgateway-dev:mainfrom
ParthMozarkar:fix/missing-dependency

Conversation

@ParthMozarkar

Copy link
Copy Markdown
Contributor

Description

This PR adds postcss-import to the devDependencies in package.json.

Rationale

The project's assets/css/postcss.config.js explicitly requires postcss-import, but the package was not listed as a direct dependency. Explicitly listing it ensures build reproducibility and prevents potential failures in clean environments or CI/CD pipelines where transitive dependencies might not be guaranteed.

Changes

  • Added postcss-import to devDependencies in package.json.
  • Updated package-lock.json accordingly.

Verification

  • Verified that postcss-import is now correctly listed in package.json.
  • Ensured the commit is signed-off according to DCO requirements.

Fixes : #743

Signed-off-by: ParthMozarkar <greatparth21@gmail.com>
@nfuden

nfuden commented May 8, 2026

Copy link
Copy Markdown

Given the current builds are passing I dont see this being necessary as a separate pr from your other pr.
Perhaps in this pr we enhance the action pipeline so that we dont have this drift in general?

@kristin-kronstain-brown

Copy link
Copy Markdown
Contributor

@ParthMozarkar Would you like to do anything more here?

@ParthMozarkar

Copy link
Copy Markdown
Contributor Author

@ParthMozarkar Would you like to do anything more here?

Umm...so sorry I wasn't present here ..was just busy in my exams...happy for reviews !! Do let me know

@kristin-kronstain-brown

Copy link
Copy Markdown
Contributor

@ParthMozarkar Sorry I was probably cryptic! I meant did you want to address @nfuden's comments? Or could we just close this? I wasn't sure what the other PR was.

@ParthMozarkar

Copy link
Copy Markdown
Contributor Author

@ParthMozarkar Sorry I was probably cryptic! I meant did you want to address @nfuden's comments? Or could we just close this? I wasn't sure what the other PR was.

Ahh !! Sorry my bad...yes I"ll address @nfuden's comment before closing the pr !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: add missing postcss-import dependency to package.json

3 participants