build: add missing postcss-import dependency#744
Conversation
Signed-off-by: ParthMozarkar <greatparth21@gmail.com>
|
Given the current builds are passing I dont see this being necessary as a separate pr from your other pr. |
|
@ParthMozarkar Would you like to do anything more here? |
Umm...so sorry I wasn't present here ..was just busy in my exams...happy for reviews !! Do let me know |
|
@ParthMozarkar Sorry I was probably cryptic! I meant did you want to address @nfuden's comments? Or could we just close this? I wasn't sure what the other PR was. |
Ahh !! Sorry my bad...yes I"ll address @nfuden's comment before closing the pr !! |
Description
This PR adds
postcss-importto thedevDependenciesinpackage.json.Rationale
The project's
assets/css/postcss.config.jsexplicitly requirespostcss-import, but the package was not listed as a direct dependency. Explicitly listing it ensures build reproducibility and prevents potential failures in clean environments or CI/CD pipelines where transitive dependencies might not be guaranteed.Changes
postcss-importtodevDependenciesinpackage.json.package-lock.jsonaccordingly.Verification
postcss-importis now correctly listed inpackage.json.Fixes : #743