Skip to content

change(android): enable autocorrect by default 馃殏 #16389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jahorton wants to merge 1 commit into from
Closed

change(android): enable autocorrect by default 馃殏 #16389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/KMEA/app/src/main/java/com/keyman/engine/KMManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ public int toInt() {
public static int KeyboardHeight_Context_Landscape_Current = 0; // Current landscape height

// Default prediction/correction setting
public static final int KMDefault_Suggestion = SuggestionType.PREDICTIONS_WITH_CORRECTIONS.toInt();
public static final int KMDefault_Suggestion = SuggestionType.PREDICTIONS_WITH_AUTO_CORRECT.toInt();

@mcdurdin mcdurdin Aug 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this switch this feature on for upgrades or only for new users?

@jahorton jahorton Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This affects the default selection when installing packages.

Answers I'm sure about:

  • With this change in place, installing a keyboard/model for a language not previously installed will set autocorrect active for it by default - whether or not upgraded from a prior 19.0-alpha or it's a newly installed Keyman for Android.

Answers I suspect:

  • I believe that if the toggle was never manipulated for an already-installed language, it will automatically be set to autocorrect on upgrade.
    • No actual custom setting was ever made for that language, so it has been operating on whatever the default value is... and updating the source of the default should carry through.
    • Which implies that for users who never muck about with those settings, autocorrect would likely auto-activate on upgrade.

Would you like me to confirm the above suspicion?

@mcdurdin mcdurdin Aug 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yes, it would be good for us to be clear on the way the setting works.

@jahorton jahorton Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suspicions were correct. Testing against the current master (merged epic/autocorrect), then updating to this PR's branch's version, sees autocorrect go enabled by default for keyboards.

@jahorton jahorton Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Furthermore, if the setting was previously manipulated (and thus, is not default reliant), it does not automatically change to the new default.


// Keyman files
protected static final String KMFilename_KeyboardHtml = "keyboard.html";
Expand Down