Skip to content

feat(windows): pass UI language to keyboard download page - #16364

Merged
mcdurdin merged 1 commit into
masterfrom
feat/windows/15542-pass-lang-parameter-to-keyboard-download
Aug 17, 2026
Merged

feat(windows): pass UI language to keyboard download page#16364
mcdurdin merged 1 commit into
masterfrom
feat/windows/15542-pass-lang-parameter-to-keyboard-download

Conversation

@mcdurdin

Copy link
Copy Markdown
Member

Fixes: #15542
Relates-to: keymanapp/keyman.com#818

User Testing

Note: wait for keymanapp/keyman.com#818 to merge before testing.

  • TEST_LANG: Switch to one of the supported UI languages for keyboard search (German, Spanish, French, Khmer) in Keyman Configuration, and click Download Keyboard. The dialog should appear in the target language.

  • TEST_FALLBACK: Switch to an unsupported UI language for keyboard search, such as Czech, Turkish, or Amharic. Verify that the Download Keyboard dialog appears in English (except for the buttons, which may appear in the UI language).

@github-project-automation github-project-automation Bot moved this to Todo in Keyman Aug 13, 2026
@keymanapp-test-bot keymanapp-test-bot Bot added has-user-test user-test-required User tests have not been completed labels Aug 13, 2026
@keymanapp-test-bot

keymanapp-test-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

@rc-swag rc-swag left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Meng-Heng

Copy link
Copy Markdown
Contributor

Test Specs

  1. Keyman for Windows v19.0.266-alpha-test-16364
  2. Windows 10 Bootcamp

Test Results

  • TEST_LANG (PASSED):
  1. Start Keyman -> Keyman Configuration -> Display Language -> Khmer
  2. Click on "Download keyboard..."
  3. Search for Khmer Angkor
  4. VERIFIED: The dialog appears in Khmer
  5. Install the keyboard successfully
  6. VERIFIED: Throughout the process of downloading the keyboard, the language remains in Khmer.
  • TEST_FALLBACK (PASSED):
  1. Keyman Configuration -> Display Language -> Tamil
  2. Click on "Download keyboard..."
  3. Search for EuroLatin
  4. VERIFIED: The dialog appears in English, except for the buttons
  5. Install the keyboard successfully.

@keymanapp-test-bot keymanapp-test-bot Bot removed the user-test-required User tests have not been completed label Aug 14, 2026
@keyman-server keyman-server modified the milestones: A19S35, A19S36 Aug 17, 2026
@mcdurdin
mcdurdin merged commit eebe740 into master Aug 17, 2026
10 checks passed
@mcdurdin
mcdurdin deleted the feat/windows/15542-pass-lang-parameter-to-keyboard-download branch August 17, 2026 05:57
@github-project-automation github-project-automation Bot moved this from Todo to Done in Keyman Aug 17, 2026
@keyman-server

Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.268-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

feat(windows): pass current display language to keyboard search

4 participants