Remove pcap flavours from the report zip archive#2992
Open
RobertBendun wants to merge 2 commits into
Open
Conversation
Pcap flavours carry information that can be found already within the archive - original pcap and TLS info are still included. Removing them from archive can significantly reduce the resulting archive size and reduce the time needed for the API endpoint response
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the tasks_report view to exclude several derived pcap files from the 'all' report format, aiming to reduce the size of generated archives. A suggestion was made to also include dump.pcapng in the exclusion list, as it is a large artifact that aligns with the goal of minimizing archive size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pcap flavours carry information that can be found already within the archive - original pcap and TLS info are still included.
Removing them from archive can significantly reduce the resulting archive size and reduce the time needed for the API endpoint response
Justification
Analysis with a lot of network traffic produced this artifacts:
When trying to download zip archive with
apiv2/tasks/get/report/<id>/all/zip/, archive creation took over 3 minutes (when we increased nginx proxy timeout) blocking the whole CPU core for this computation.Alternative solution
I understand if you want to keep all of the resulting pcap flavours in the resulting archive - I propose as alternative solution another type of export, something like
all_but_derived_pcaps(better name needs to be found).