add an option to kvm-qemu.sh for masking apt-daily-upgrade.timer#2988
add an option to kvm-qemu.sh for masking apt-daily-upgrade.timer#2988VVelox wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a configuration option to mask the apt-daily-upgrade.timer in the KVM installer script and includes several dependency downgrades in requirements.txt. Feedback focuses on the placement of the masking logic, which currently executes before root privilege checks and during non-installation commands, potentially causing script failures. Additionally, a suggestion was made to use string comparison for the toggle variable to improve robustness against non-numeric values. The reviewer also flagged the dependency downgrades as potentially unintentional or requiring justification, as they appear unrelated to the primary objective of the PR.
| django-allauth==65.13.0 ; python_version >= "3.10" and python_version < "4.0" \ | ||
| --hash=sha256:119c0cf1cc2e0d1a0fe2f13588f30951d64989256084de2d60f13ab9308f9fa0 \ | ||
| --hash=sha256:7d7b7e7ad603eb3864c142f051e2cce7be2f9a9c6945a51172ec83d48c6c843b |
There was a problem hiding this comment.
The changes in this file consist of downgrades for several core dependencies (e.g., django, requests, orjson, protobuf). These changes appear unrelated to the PR's objective of masking the apt-daily-upgrade.timer. If these downgrades were unintentional, please revert them to maintain the latest versions. If they are required for compatibility, please provide a justification in the PR description.
|
Blarg? Did the requirements thing function properly? |
2 participants
I've found apt-daily-upgrade.timer can occasionally trigger systemd sharting it's self and deciding to stop libvirt, which in turn causes issues with CAPEv2 as it can no longer talk to libvirt.