Optional url splitter#2967
Open
MMikePL wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the URL splitting logic in the submission view to allow disabling the splitter by leaving the configuration empty. I have reviewed the changes and suggest incorporating a list comprehension to strip whitespace and filter out empty entries during the split process to improve robustness against malformed input.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows disabling URL splitting during submission by leaving the url_splitter configuration value empty and handling such value in the code. It also changes the default behavior to not split URLs, addressing issues where valid URLs containing commas (the previous default) were incorrectly fragmented.
Argument for Change
The previous default splitter was a comma (","). However, commas are valid characters in URLs (e.g., in query parameters or certain path structures). Using a comma as a mandatory default splitter caused many legitimate URLs to be incorrectly broken into invalid fragments during submission. This change ensures that by default, URLs are preserved exactly as entered, while still allowing users to opt-in to multi-URL submission by configuring a specific delimiter.
Configuration Limitation
Due to how configuration values are parsed and stripped, setting url_splitter to a space is effectively treated as an empty value (disabling splitting). If space-delimited splitting is required in the future, a more complex solution may be necessary, such as implementing a specific placeholder like "whitespace" in the config that the code would then interpret as a command to split by whitespace.