Open
Conversation
bd5be04 to
ff72634
Compare
This change addresses the requirement to reduce the frequency of creating Checkout Nodes instead of setting frequency limits on Maestro Jobs (which might result in empty Checkouts in the Web Dashboard). Configuration values in use do not provide a fix for the reported issue. They were chosen to verify this approach on the Maestro Staging instance. A tree has been selected using following criteria: - adds as little as possible load for the Staging build cluster instance - preferably has only one monitored branch which doesn't get updated often - is related to the netdev tree already present in the Docker Compose deployment. Resolves: kernelci/kernelci-core#2857 Signed-off-by: Paweł Wieczorek <pawiecz@collabora.com>
This change adds a daily Trigger service to the K8s-based deployment which is used in e.g. Maestro Production instance. Configuration values in use provide an actual fix to the user-reported issue instead of being arbitrarily chosen for testing purposes as in the case of Docker Compose-based deployment. This change might need a revisit to fold copied and pasted container configuration for the Trigger service into a reusable template. Resolves: kernelci/kernelci-core#2857 Signed-off-by: Paweł Wieczorek <pawiecz@collabora.com>
ff72634 to
a5fe058
Compare
a-wai
reviewed
Oct 9, 2025
| - '--settings=${KCI_SETTINGS:-/home/kernelci/config/kernelci.toml}' | ||
| - 'run' | ||
| - '--poll-period=86400' | ||
| - '--trees=aaptel' |
Contributor
There was a problem hiding this comment.
Suggested change
| - '--trees=aaptel' | |
| - '--trees=chromiumos' |
Shouldn't it mirror the kube config below?
Contributor
|
@pawiecz I'm checking what is left to do here in order to finally merge this service, but it seems you got it all pretty much covered. Is there anything I could help with? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: kernelci/kernelci-core#2857