fix: rename cache key for tree details builds to avoid key collision#1849
Merged
gustavobtflores merged 1 commit intokernelci:mainfrom Apr 13, 2026
Merged
Conversation
backend/kernelCI_app/queries/tree.py
Outdated
| Fetch builds for a given tree commit. | ||
| """ | ||
| cache_key = "treeDetailsBuilds" | ||
| cache_key = "treeDetailsBuildsDirect" |
Collaborator
There was a problem hiding this comment.
since direct already has some meaning in the sense of "the endpoints that don't require all the tree information", I would say it's better to rename treeDetails[type] to treeData[type] or treeDetais[type]Data, which would also reflect the function name
gustavobtflores
force-pushed
the
fix/tree-details-cache-key-collision
branch
from
f18075a to
9e3cac8
Compare
MarceloRobert
approved these changes
Apr 13, 2026
Collaborator
MarceloRobert
left a comment
MarceloRobert
left a comment
There was a problem hiding this comment.
I was thinking about changing the cache_key of the other function, but this works too. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a cache key collision between
get_tree_details_buildsandget_tree_data(data_type="builds"). Both functions used the identical cache key "treeDetailsBuilds", causing the summary endpoint to populate the cache with dict rows. When the builds endpoint subsequently accessed that cache,get_tree_datatried to read those dicts as tuples via positional indexingrow[0], triggeringKeyError: 0.Changes
get_tree_details_buildscache key from "treeDetailsBuilds" to "treeDetailsBuildsDirect" to avoid collision withget_tree_data