Skip to content

Sass output breaking loadStyleSheet() #93

Description

@CHEWX

I kept getting an error with IE8 on line 383:

    function loadStyleSheet( url ) {
        xhr.open("GET", url, false);
        xhr.send();
        return (xhr.status==200) ? xhr.responseText : EMPTY_STRING;
    };

This is because my Sass was being outputted as compressed, it needs to be compact.

I think this should be on the docs, took a long while to figure out.

The best way would be to output 2 stylesheets. One as compressed 'main.css' and one 'main-ie.css' as compact and conditionally load them.

Activity

  1. changed the title [-]Sass Output breaking loadStyleSheet()[/-] [+]Sass output breaking loadStyleSheet()[/+] on Feb 24, 2015
  2. ArmorDarks commented on May 30, 2015

    @ArmorDarks

    Having two versions of css just because of that error doesn't sound good, to be honest...

    Duplicate of #66

  3. ganlanyuan commented on Jul 29, 2016

    @ganlanyuan

    I encountered this problem too, but later I figured out that Selectivizr has some issues dealing with @import rule and urls. After I change lines 447-455

    return loadStyleSheet(url).replace(RE_COMMENT, EMPTY_STRING).
                replace(RE_IMPORT, function( match, quoteChar, importUrl, quoteChar2, importUrl2, media ) {
                    var cssText = parseStyleSheet(resolveUrl(importUrl || importUrl2, url));
                    return (media) ? "@media " + media + " {" + cssText + "}" : cssText;
                }).
                replace(RE_ASSET_URL, function( match, isBehavior, quoteChar, assetUrl ) { 
                    quoteChar = quoteChar || EMPTY_STRING;
                    return isBehavior ? match : " url(" + quoteChar + resolveUrl(assetUrl, url, true) + quoteChar + ") "; 
    });

    to

    return loadStyleSheet(url).replace(RE_COMMENT, EMPTY_STRING);

    This was fixed.
    Though I don't know the purpose of these two **replace()**s.

  4. ganlanyuan commented on Jul 29, 2016

    @ganlanyuan

    Sorry,
    jesstelford actually fixed this issue. Check #69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions