feat: add MongoDB Atlas provider - #6658
Open
BaesTheorem wants to merge 1 commit into
Open
Conversation
Member
|
hey @BaesTheorem , do you use Keep? |
Author
Heya! I do not. I run a fair amount of self-hosted monitoring and automation at home, but not Keep yet. I went looking for a well-maintained project in a space I know so I could start contributing, and this one was tagged "Good First Issue" and still open, so I went for it. If it helps, I can stand up Keep with docker-compose and a free-tier Atlas cluster and run the pull path end to end. The webhook path is already tested against the sample payload from the Atlas docs, and the PR notes what I couldn't exercise. :) Happy to make whatever changes you want either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1839
Adds a MongoDB Atlas provider with both directions:
GET /api/atlas/v2/groups/{groupId}/alerts, digest auth, versioned2023-01-01Accept header) with pagination.api_keyquery parameter.A few mapping decisions worth flagging for review:
warningand keepeventTypeNameavailable for mapping rules downstream. TRACKING maps topending, andacknowledgedUntilmarks an open alertacknowledged.id, which is stable across an alert's open/close lifecycle.Verification: black 24.10.0 / isort 5.13.2 / ruff 0.11.4 (the repo pins) pass; docs snippet regenerated with
scripts/docs_render_provider_snippets.pyand--validatepasses; the formatter is exercised againstAlertDtowith the sample payload from Atlas's webhook docs (OPEN/CLOSED/TRACKING/acknowledged transitions and a minimal payload). I don't have an Atlas project with live alerts to test the pull path end to end, so that part is written against the API reference and would benefit from a check by someone who does.