fix: lower log level for ScaledObject paused replicas transitioning state#7650
Open
aliaqel-stripe wants to merge 4 commits intokedacore:mainfrom
Open
fix: lower log level for ScaledObject paused replicas transitioning state#7650aliaqel-stripe wants to merge 4 commits intokedacore:mainfrom
aliaqel-stripe wants to merge 4 commits intokedacore:mainfrom
Conversation
…tate The "ScaledObject paused replicas are being scaled" message was returned as an error, causing the controller to log it at error level and mark the ScaledObject ReadyCondition=False. This is a transient, expected state during the normal pausing transition and should not be treated as an error. Log at warning level and return nil so the ScaledObject is not incorrectly marked as unhealthy during this transition. Fixes kedacore#6604 Signed-off-by: Ali Aqel <aliaqel@stripe.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
Signed-off-by: Ali Aqel <aliaqel@stripe.com>
wozniakjan
approved these changes
Apr 21, 2026
Member
wozniakjan
left a comment
wozniakjan
left a comment
There was a problem hiding this comment.
lgtm, just would like to wait for #7664 to merge first
rickbrouwer
added
the
waiting-on-other-pr
wozniakjan
added
the
Awaiting/2nd-approval
JorTurFer
approved these changes
May 7, 2026
rickbrouwer
added
merge-conflict
Member
|
Related PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When introducing the
autoscaling.keda.sh/paused-replicasannotation on a ScaledObject, there is a brief window during the first reconciliation where the annotation is set but thePausedConditionstatus hasn't been committed yet. During this window, the controller was returning a non-nil error, causing:logger.Error(...)— error-level log spam on every reconciliation during a normal, expected pausing transitionReadyCondition=Falsewith reasonScaledObjectCheckFailed— incorrectly marking the ScaledObject as unhealthyWarningKubernetes event — unnecessary noise in the event streamFix: log at info level and return
nilso this expected transitional state is not treated as a failure.Checklist
Wait for:
Fixes #6604