test: add e2e test for openstack metrics scaler by Abhicodeitout · Pull Request #7638 · kedacore/keda

Abhicodeitout · 2026-04-10T14:15:02Z

Provide a description of what has been changed

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added (if applicable)
Ensure make generate-scalers-schema has been run to update any outdated generated files
Changelog has been updated and is aligned with our changelog requirements, only when the change impacts end users
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

snyk-io · 2026-04-10T14:15:18Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

github-actions · 2026-04-10T14:15:26Z

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

rickbrouwer · 2026-04-10T19:23:05Z

Hi! I see in the description that you want to provide an e2e test, for which thanks.
However, I also see a large number of adjustments to other files, which seems unnecessary to me.

Abhicodeitout · 2026-04-10T23:50:06Z

@rickbrouwer So should I revert those and fix only tests one

rickbrouwer · 2026-04-11T06:06:47Z

Yes please, that keeps the PR scoped

Abhicodeitout · 2026-04-12T06:54:38Z

@rickbrouwer is there some issue in the Github actions

rickbrouwer · 2026-04-12T07:04:37Z

@rickbrouwer is there some issue in the Github actions

You need to run ‘go fmt .’ in the directory where you added the file

Abhicodeitout · 2026-04-12T07:27:28Z

@rickbrouwer is there some issue in the Github actions

You need to run ‘go fmt .’ in the directory where you added the file

I have ran that but then also

Abhicodeitout · 2026-04-12T07:34:02Z

@dangerousplay is there any plublic group on discord slack or telegram where we discuss to the issues or workspace

rickbrouwer · 2026-04-12T12:30:23Z

I have ran that but then also

Perhaps you ran it from the wrong place. Otherwise, go to the directory and run it there.

cd tests/scalers/openstack_metrics
go fmt .

Also, please sign your commits (DCO).

rickbrouwer · 2026-04-12T12:31:55Z

@dangerousplay is there any plublic group on discord slack or telegram where we discuss to the issues or workspace

I think you're posting this in the wrong place?

Abhicodeitout · 2026-04-13T12:59:19Z

@rickbrouwer can you review ?

Revert unrelated changes from this branch so PR kedacore#7638 only contains the intended OpenStack metrics e2e test work. This commit removes accidental modifications to workflow files, changelog, and metrics API scaler implementation/tests that belong to a separate effort. Also aligns with reviewer request to keep the PR narrowly scoped. Signed-off-by: Abhishek Kumar Kushwaha <abhithegabbar@gmail.com>

Abhicodeitout · 2026-04-14T15:35:17Z

@rickbrouwer can you review ?

rickbrouwer · 2026-04-14T17:56:52Z

Can you undo the GitHub workflows and changelog changes?

Abhicodeitout · 2026-04-15T10:58:52Z

@rickbrouwer i have reverted changes can you review ?

rickbrouwer · 2026-04-15T11:16:43Z

There are still adjustments out of scope.

Abhicodeitout · 2026-04-16T12:34:19Z

@rickbrouwer can u look now hope this time it goes well

rickbrouwer · 2026-04-16T13:31:44Z

Looks good overall, but a few things caught my eye.

PostMeasure constructs the URL as metricsURL + "/v1/metric/" + metricID + "/measures", while the scaler does path.Join(openstackMetricsURL.Path, metricID+"/measures"). Are those two hitting the same endpoint for the same OPENSTACK_METRICS_URL value?

Further, with granularity=300, the scaler computes (300/60) - 1 = 4 and then adds that to time.Now(), setting start roughly 4 minutes into the future. Wouldn't it return an empty result for that window, meaning the scaler always returns 0, which would make testScaleOut fail regardless of the value posted?

Abhicodeitout · 2026-04-16T16:24:01Z

@rickbrouwer

both fixed.

URL mismatch — PostMeasure was appending /v1/metric/<id>/measures to the raw base URL, while the scaler appends <id>/measures directly to metricsURL. Aligned PostMeasure to use metricsURL + "/" + metricID + "/measures" so both paths hit the same endpoint, assuming OPENSTACK_METRICS_URL already includes /v1/metric.

Time window — granularity=300 was computing (300/60)-1 = 4 and adding that to time.Now(), setting start ~4 minutes in the future and guaranteeing an empty response.

rickbrouwer · 2026-04-18T07:51:43Z

/run-e2e openstack
Update: You can check the progress here

Abhicodeitout · 2026-05-01T02:09:29Z

@rickbrouwer @JorTurFer CAN YOU TRIGGER TEST RUN ?

Signed-off-by: Abhishek Kumar Kushwaha <abhithegabbar@gmail.com>

Abhicodeitout · 2026-05-01T02:46:33Z

@rickbrouwer @JorTurFer CAN YOU RUN THE TESTS ?

Abhicodeitout · 2026-05-01T06:17:09Z

@rickbrouwer what happened are there any mis changes ?

rickbrouwer · 2026-05-01T06:46:00Z

Please avoid all caps, it comes across as impolite.

rickbrouwer · 2026-05-01T06:48:19Z

I see that the fix you made earlier is suddenly gone. Is it no longer needed?

Abhicodeitout · 2026-05-01T09:04:02Z

@rickbrouwer actually earlier rebase went wrong now i have corrected it can you trigger it now ? i tried to mock as suggested by @JorTurFer for gnoochi and tested it went well

rickbrouwer · 2026-05-01T16:07:25Z

I mean, you initially made a change in the OpenStack scaler itself due to a bug, right? But I don't see that in this pr anymore.

Signed-off-by: Abhishek Kumar Kushwaha <abhithegabbar@gmail.com>

Abhicodeitout · 2026-05-02T12:23:02Z

@rickbrouwer i have updated the code and fixed the bug and tested by mocking. Can you trigger the test ?

rickbrouwer · 2026-05-02T12:32:58Z

/run-e2e openstack_metrics
Update: You can check the progress here

Signed-off-by: Abhishek Kumar Kushwaha <abhithegabbar@gmail.com>

rickbrouwer · 2026-05-05T06:04:37Z

/run-e2e openstack_metrics
Update: You can check the progress here

Abhicodeitout · 2026-05-05T07:04:18Z

If its good can i get a merge @rickbrouwer @JorTurFer

rickbrouwer · 2026-05-05T07:27:27Z

The test was skipped due to a missing variable OPENSTACK_METRICS_URL:

2026-05-05T06:29:22.8359169Z     openstack_metrics_test.go:***5***: skipping OpenStack metrics test: unable to discover metric service from catalog and OPENSTACK_METRICS_URL is not set: scaler could not find the service URL dynamically. Either provide it in the scaler parameters or check your OpenStack configuration: service 'metric' not found in catalog. Please, provide different credentials or reach to your OpenStack cluster manager
2026-05-05T06:29:22.8362021Z --- SKIP: TestScaler (***.66s)

Abhicodeitout · 2026-05-05T07:58:01Z

The test was skipped due to a missing variable OPENSTACK_METRICS_URL:

2026-05-05T06:29:22.8359169Z     openstack_metrics_test.go:***5***: skipping OpenStack metrics test: unable to discover metric service from catalog and OPENSTACK_METRICS_URL is not set: scaler could not find the service URL dynamically. Either provide it in the scaler parameters or check your OpenStack configuration: service 'metric' not found in catalog. Please, provide different credentials or reach to your OpenStack cluster manager
2026-05-05T06:29:22.8362021Z --- SKIP: TestScaler (***.66s)

So what should be that url ? @rickbrouwer

Signed-off-by: Abhishek Kumar Kushwaha <abhithegabbar@gmail.com>

Abhicodeitout · 2026-05-05T09:36:28Z

@rickbrouwer can you start test

Abhicodeitout · 2026-05-05T11:52:17Z

@rickbrouwer can you trigger test?

rickbrouwer · 2026-05-05T18:24:08Z

/run-e2e openstack_metrics
Update: You can check the progress here

rickbrouwer · 2026-05-06T06:28:56Z

=== RUN TestScaler
openstack_metrics_test.go:5: skipping OpenStack metrics test: unable to discover metric service from catalog and OPENSTACK_METRICS_URL is not set: metric lookup failed: scaler could not find the service URL dynamically. Either provide it in the scaler parameters or check your OpenStack configuration: service 'metric' not found in catalog. Please, provide different credentials or reach to your OpenStack cluster manager; gnocchi lookup failed: scaler could not find the service URL dynamically. Either provide it in the scaler parameters or check your OpenStack configuration: service 'gnocchi' not found in catalog. Please, provide different credentials or reach to your OpenStack cluster manager
--- SKIP: TestScaler (***.***5s)

Abhicodeitout · 2026-05-08T09:51:41Z

@rickbrouwer
If your cloud truly has no metrics endpoint in its Keystone catalog, the e2e test will still skip unless OPENSTACK_METRICS_URL is set. The change only fixes the false-negative case where the endpoint exists under service type metric but was not being resolved

Signed-off-by: Abhishek Kumar Kushwaha <abhithegabbar@gmail.com>

Abhicodeitout · 2026-05-08T11:13:24Z

@rickbrouwer can you trigger test run

rickbrouwer · 2026-05-08T12:15:46Z

/run-e2e openstack_metrics
Update: You can check the progress here

Abhicodeitout requested a review from a team as a code owner April 10, 2026 14:15

keda-automation requested a review from a team April 10, 2026 14:15

Abhicodeitout mentioned this pull request Apr 10, 2026

Add e2e test for Openstack Metrics Scaler #4155

Open

Abhicodeitout force-pushed the metrics-scaler branch 2 times, most recently from a942e02 to 3021816 Compare April 12, 2026 06:36

Abhicodeitout force-pushed the metrics-scaler branch 2 times, most recently from b1ff136 to 85a87c4 Compare April 13, 2026 12:32

Abhicodeitout force-pushed the metrics-scaler branch from d4cbf0c to 374b43c Compare April 15, 2026 10:57

Abhicodeitout force-pushed the metrics-scaler branch from 5aac460 to 12158be Compare April 16, 2026 16:25

fix(openstack): remove mock token fallback and satisfy gci import order

b8cc009

Signed-off-by: Abhishek Kumar Kushwaha <abhithegabbar@gmail.com>

fix(openstack): use lookback window for metrics start

ea424b0

Signed-off-by: Abhishek Kumar Kushwaha <abhithegabbar@gmail.com>

Abhicodeitout added 2 commits May 5, 2026 05:31

fix(test): skip openstack metrics e2e when metric service not in catalog

42f084b

Signed-off-by: Abhishek Kumar Kushwaha <abhithegabbar@gmail.com>

Merge branch 'main' into metrics-scaler

d15d851

Abhicodeitout requested review from JorTurFer and rickbrouwer May 5, 2026 07:03

test: add openstack metrics endpoint fallback

4cb5dfa

Signed-off-by: Abhishek Kumar Kushwaha <abhithegabbar@gmail.com>

Abhicodeitout added 3 commits May 8, 2026 09:53

fix: resolve openstack metric service type lookup

b03a5c6

Signed-off-by: Abhishek Kumar Kushwaha <abhithegabbar@gmail.com>

Merge branch 'main' into metrics-scaler

dbecc5f

fix: satisfy openstack auth golangci lint

2e54755

Signed-off-by: Abhishek Kumar Kushwaha <abhithegabbar@gmail.com>

Conversation

Abhicodeitout commented Apr 10, 2026 • edited by rickbrouwer Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

snyk-io Bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

github-actions Bot commented Apr 10, 2026

Uh oh!

rickbrouwer commented Apr 10, 2026

Uh oh!

Abhicodeitout commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Apr 11, 2026

Uh oh!

Abhicodeitout commented Apr 12, 2026

Uh oh!

rickbrouwer commented Apr 12, 2026

Uh oh!

Abhicodeitout commented Apr 12, 2026

Uh oh!

Abhicodeitout commented Apr 12, 2026

Uh oh!

rickbrouwer commented Apr 12, 2026

Uh oh!

rickbrouwer commented Apr 12, 2026

Uh oh!

Abhicodeitout commented Apr 13, 2026

Uh oh!

Abhicodeitout commented Apr 14, 2026

Uh oh!

rickbrouwer commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Abhicodeitout commented Apr 15, 2026

Uh oh!

rickbrouwer commented Apr 15, 2026

Uh oh!

Abhicodeitout commented Apr 16, 2026

Uh oh!

rickbrouwer commented Apr 16, 2026

Uh oh!

Abhicodeitout commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Apr 18, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Abhicodeitout commented May 1, 2026

Uh oh!

Abhicodeitout commented May 1, 2026

Uh oh!

Abhicodeitout commented May 1, 2026

Uh oh!

rickbrouwer commented May 1, 2026

Uh oh!

rickbrouwer commented May 1, 2026

Uh oh!

Abhicodeitout commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented May 1, 2026

Uh oh!

Abhicodeitout commented May 2, 2026

Uh oh!

rickbrouwer commented May 2, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented May 5, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Abhicodeitout commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented May 5, 2026

Uh oh!

Abhicodeitout commented May 5, 2026

Abhicodeitout commented Apr 10, 2026 •

edited by rickbrouwer

Loading

snyk-io Bot commented Apr 10, 2026 •

edited

Loading

Abhicodeitout commented Apr 10, 2026 •

edited

Loading

rickbrouwer commented Apr 14, 2026 •

edited

Loading

Abhicodeitout commented Apr 16, 2026 •

edited

Loading

rickbrouwer commented Apr 18, 2026 •

edited by github-actions Bot

Loading

Abhicodeitout commented May 1, 2026 •

edited

Loading

rickbrouwer commented May 2, 2026 •

edited by github-actions Bot

Loading

rickbrouwer commented May 5, 2026 •

edited by github-actions Bot

Loading

Abhicodeitout commented May 5, 2026 •

edited

Loading

rickbrouwer commented May 5, 2026 •

edited by github-actions Bot

Loading

rickbrouwer commented May 8, 2026 •

edited by github-actions Bot

Loading