fix: raise default --kube-api-qps/--kube-api-burst to 50/100#7615
Open
Fedosin wants to merge 1 commit intokedacore:mainfrom
Open
fix: raise default --kube-api-qps/--kube-api-burst to 50/100#7615Fedosin wants to merge 1 commit intokedacore:mainfrom
Fedosin wants to merge 1 commit intokedacore:mainfrom
Conversation
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
The previous defaults (QPS=20, Burst=30) cause client-side throttling with as few as 100 ScaledObjects, adding ~5s delay per status PATCH and making scale-to-zero take 15-20 minutes instead of ~5.5 minutes. Raise all three components (operator, metrics adapter, webhooks) to QPS=50 / Burst=100 to match what other large-scale controllers use (e.g. ArgoCD 50/100) while remaining well below API server capacity. Relates to kedacore#7613 Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com>
eab4de5 to
7770299
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--kube-api-qpsfrom 20 to 50 and--kube-api-burstfrom 30 to 100 across all three components (operator, metrics adapter, webhooks)Relates to #7613
Context
The current QPS=20 / Burst=30 defaults override controller-runtime's default behavior of disabling the client-side rate limiter entirely (
QPS=-1), which relies on API Priority and Fairness (APF) for server-side throttling. This means KEDA self-throttles more aggressively than a standard controller-runtime controller would.With 100 ScaledObjects, each reconciliation cycle generates multiple status PATCH calls. Once the burst budget is exhausted, every subsequent request is throttled to the QPS rate, producing consistent ~5s delays visible in operator logs:
Raising to 50/100 provides 2.5× the throughput headroom, supporting 200-300 ScaledObjects without throttling under typical workloads.
Test plan
go build ./cmd/operator/ ./cmd/adapter/ ./cmd/webhooks/)