feat(aws): add support for externalId in AssumeRole for TriggerAuthentication#7580
Open
zeevimeytar wants to merge 1 commit intokedacore:mainfrom
Open
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
36942ff to
1726856
Compare
Author
|
Hey @JorTurFer, would appreciate your review here 😄 |
1726856 to
4b9122e
Compare
Author
|
Happy to make changes here if required, @rickbrouwer 😃 |
…uthentication Signed-off-by: Meytar Zeevi <Meytar@rocksteady.io>
4b9122e to
6a73e0b
Compare
This was referenced Apr 19, 2026
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for passing an
externalIdwhen KEDA assumes an AWS IAM role via theTriggerAuthenticationresource. The external ID is a security best practice for cross-account role assumption that prevents the "confused deputy" problem.The
externalIdis specified as a field inspec.podIdentity, consistent with howroleArnis already modeled onAuthPodIdentity:The external ID is passed to AWS STS during the
AssumeRoleAPI call, which is required when assuming roles that have ansts:ExternalIdcondition in their trust policy.Changes
ExternalID *stringfield (json:"externalId,omitempty") toAuthPodIdentityspecAwsRoleExternalIDfield toAuthorizationMetadatapodIdentity.ExternalIDtoauthParams["awsRoleExternalId"]inResolveAuthRefAndPodIdentityawsRoleExternalIdfromauthParamsinGetAwsAuthorizationExternalIDin cache key generation to ensure separate cache entries per external IDExternalIDtoAssumeRoleOptionsinretrievePodIdentityCredentials(pod identity path)ExternalIDtoAssumeRoleOptionsinGetAwsConfig(deprecated aws-eks path)Checklist
make generate-scalers-schemahas been run to update any outdated generated filesFixes #
Relates to #7388