feat(mssql): add driverName support for azuresql driver by akarki2005 · Pull Request #7567 · kedacore/keda

akarki2005 · 2026-03-21T01:15:41Z

This PR adds optional driverName support to the MSSQL scaler, allowing users to use the azuresql driver for Azure AD–based authentication.

If not specified, it defaults to sqlserver, so existing configurations remain unchanged.

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added (if applicable)
Ensure make generate-scalers-schema has been run to update any outdated generated files
Changelog has been updated and is aligned with our changelog requirements, only when the change impacts end users
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #7412
Related Docs: kedacore/keda-docs#1722

github-actions · 2026-03-21T01:15:52Z

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

snyk-io · 2026-03-21T01:16:01Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Signed-off-by: Aayush Karki <akarki2005@gmail.com>

rickbrouwer · 2026-03-23T12:02:44Z

/run-e2e mssql
Update: You can check the progress here

dttung2905

lgtm . Thanks @akarki2005 for the contribution. Can we make some changes to the integration test too ? https://github.com/kedacore/keda/blob/main/tests/scalers/mssql/mssql_test.go

Signed-off-by: Aayush Karki <akarki2005@gmail.com>

akarki2005 · 2026-03-26T00:40:46Z

Hi, I've parameterized the integration tests by driver so sqlserver and azuresql are both covered by the same test flow with isolated per-case data. Happy to adjust the structure if there's another preferred pattern.

rickbrouwer · 2026-03-26T08:21:03Z

/run-e2e mssql
Update: You can check the progress here

Signed-off-by: Aayush Karki <akarki2005@gmail.com>

akarki2005 · 2026-03-26T19:16:09Z

Hi @rickbrouwer, I've pushed a patch for the test teardown issue causing the previous e2e failure (the logs showed a duplicated cleanup of the test namespace). It should be ready for another run whenever convenient.

rickbrouwer · 2026-03-27T09:25:01Z

/run-e2e mssql
Update: You can check the progress here

akarki2005 · 2026-03-30T16:54:56Z

Hi @rickbrouwer - just following up on this PR. I’ve addressed the earlier feedback (including enum validation and the integration tests), and the latest e2e run is passing.

I noticed the previous change request is now marked as outdated, but the PR is still blocked by that review. Could you take another look when you have a chance? Happy to make any additional changes if needed.

rickbrouwer · 2026-03-30T17:02:15Z

which PR do you mean that is outdated?

akarki2005 · 2026-03-30T19:17:35Z

Hi @rickbrouwer, sorry for the confusion - I meant to say the earlier review comments on this PR are now resolved.

I was hoping for another review on this PR to check if everything looks good or if there's anything else I should address. Thanks!

rickbrouwer · 2026-03-31T05:41:07Z

I will review your PR soon. Sometimes that takes a bit longer due to other work and other reviews. The maintainers and reviewers will see that all checks are green and will surely do a review soon as well.

rickbrouwer

The unit tests are incorrect regarding expectedConnectionString. However, the test passed. I suspect there is an error somewhere in the test causing the check to be incorrect. Can you check that?

rickbrouwer · 2026-03-31T05:59:08Z

@dttung2905 asked for an E2E test. The drivers are currently being tested in the E2E, so that is great. However, I think it would be valuable if we specifically included Azure AD Auth (managed identity, workload identity, etc.) in the E2E test via the Azure SQL driver.

dttung2905 · 2026-03-31T19:26:55Z

I totally agree with @rickbrouwer on this

Signed-off-by: Aayush Karki <akarki2005@gmail.com>

akarki2005 · 2026-04-06T04:57:27Z

Hi, thanks so much for the detailed feedback and suggestions - I've made some changes to fix the identified gaps.

I've fixed the incorrect expectedConnectionString values, and have updated the test logic itself to now explicitly validate the connection string.
Regarding Azure AD auth, I added an e2e test for Azure SQL using the azuresql driver with workload identity. The test mirrors existing structure in tests/scalers/postgressql/azure_postgressql_flex_server_aad_wi_test.go.

Happy to make additional adjustments to the test structure or coverage if needed.

…r-driver-name-param

rickbrouwer · 2026-04-06T18:06:46Z

+spec:
+    secretTargetRef:
+    - parameter: password
+      name: {{.SecretName}}
+      key: mssql-sa-password


Suggested change

spec:

secretTargetRef:

- parameter: password

name: {{.SecretName}}

key: mssql-sa-password

spec:

secretTargetRef:

- parameter: password

name: {{.SecretName}}

key: mssql-sa-password

rickbrouwer · 2026-04-06T18:11:19Z

+		"replica count should be %d after 3 minutes", data.MaxReplicaCount)
+}
+
+func testScaleIn(t *testing.T, kc *kubernetes.Clientset, data templateData) {


I'm taking a quick look at how this is going to work. I see an activation of 10 and another 10 in the scaleout. But shouldn't those rows be cleared to ScaleIn?

rickbrouwer · 2026-04-06T18:14:13Z

 }

 type mssqlMetadata struct {
+	DriverName            string  `keda:"name=driverName,			 order=authParams;triggerMetadata, enum=sqlserver;azuresql, default=sqlserver"`


There are some tabs and spaces between driverName and the order. Can you make them spaces only?

rickbrouwer · 2026-04-30T19:16:17Z

Any status @akarki2005 ?

keda-automation requested review from a team March 21, 2026 01:15

akarki2005 force-pushed the feature/mssql-scaler-driver-name-param branch 2 times, most recently from e8a507f to 5d73b28 Compare March 21, 2026 01:50

feat(mssql): add driverName support for azuresql driver

5fde208

Signed-off-by: Aayush Karki <akarki2005@gmail.com>

akarki2005 force-pushed the feature/mssql-scaler-driver-name-param branch from 5d73b28 to 5fde208 Compare March 21, 2026 12:57

akarki2005 mentioned this pull request Mar 21, 2026

docs: add driverName parameter to MSSQL scaler kedacore/keda-docs#1722

Open

1 task

akarki2005 marked this pull request as ready for review March 21, 2026 13:42

akarki2005 mentioned this pull request Mar 21, 2026

MSSQL scaler supports all Azure Active Directory authentication methods provided by driver #7412

Open

rickbrouwer requested changes Mar 23, 2026

View reviewed changes

Comment thread pkg/scalers/mssql_scaler.go Outdated

Add enum validation for MSSQL driverName

75ff355

Signed-off-by: Aayush Karki <akarki2005@gmail.com>

keda-automation requested a review from a team March 23, 2026 11:27

akarki2005 requested a review from rickbrouwer March 23, 2026 16:23

dttung2905 reviewed Mar 24, 2026

View reviewed changes

add mssql integration test coverage for driverName param

6edd6fd

Signed-off-by: Aayush Karki <akarki2005@gmail.com>

keda-automation requested a review from a team March 25, 2026 16:59

akarki2005 requested a review from dttung2905 March 25, 2026 17:29

akarki2005 added 2 commits March 25, 2026 20:04

use sqlserver DSN scheme for all mssql drivers

477dd40

Signed-off-by: Aayush Karki <akarki2005@gmail.com>

added azuresql driver integration test coverage

8c578c7

Signed-off-by: Aayush Karki <akarki2005@gmail.com>

semgrep-code-kedacore Bot reviewed Mar 26, 2026

View reviewed changes

Comment thread tests/scalers/mssql/mssql_standalone/mssql_test.go

clean up e2e test resources in a single pass

d4a89c9

Signed-off-by: Aayush Karki <akarki2005@gmail.com>

rickbrouwer reviewed Mar 31, 2026

View reviewed changes

Comment thread pkg/scalers/mssql_scaler_test.go Outdated

Comment thread pkg/scalers/mssql_scaler_test.go Outdated

Comment thread pkg/scalers/mssql_scaler_test.go Outdated

add Azure workload identity e2e tests

239c0da

Signed-off-by: Aayush Karki <akarki2005@gmail.com>

keda-automation requested a review from a team April 6, 2026 04:33

semgrep-code-kedacore Bot reviewed Apr 6, 2026

View reviewed changes

Comment thread tests/scalers/mssql/mssql_standalone/mssql_test.go

Merge remote-tracking branch 'upstream/main' into feature/mssql-scale…

90ce961

…r-driver-name-param

akarki2005 force-pushed the feature/mssql-scaler-driver-name-param branch from b1f4084 to 90ce961 Compare April 6, 2026 17:34

rickbrouwer reviewed Apr 6, 2026

View reviewed changes

rickbrouwer added waiting-author-response All PR's or Issues where we are waiting for a response from the author merge-conflict This PR has a merge conflict labels Apr 9, 2026

Conversation

akarki2005 commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

github-actions Bot commented Mar 21, 2026

Uh oh!

snyk-io Bot commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

Uh oh!

rickbrouwer commented Mar 23, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dttung2905 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

akarki2005 commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Mar 26, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akarki2005 commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Mar 27, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akarki2005 commented Mar 30, 2026

Uh oh!

rickbrouwer commented Mar 30, 2026

Uh oh!

akarki2005 commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Mar 31, 2026

Uh oh!

rickbrouwer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rickbrouwer commented Mar 31, 2026

Uh oh!

dttung2905 commented Mar 31, 2026

Uh oh!

Uh oh!

akarki2005 commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

rickbrouwer Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

rickbrouwer Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

rickbrouwer commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

akarki2005 commented Mar 21, 2026 •

edited

Loading

snyk-io Bot commented Mar 21, 2026 •

edited

Loading

rickbrouwer commented Mar 23, 2026 •

edited by github-actions Bot

Loading

akarki2005 commented Mar 26, 2026 •

edited

Loading

rickbrouwer commented Mar 26, 2026 •

edited by github-actions Bot

Loading

akarki2005 commented Mar 26, 2026 •

edited

Loading

rickbrouwer commented Mar 27, 2026 •

edited by github-actions Bot

Loading

akarki2005 commented Mar 30, 2026 •

edited

Loading

akarki2005 commented Apr 6, 2026 •

edited

Loading