Deploy with KEDA_HTTP_TLS_CIPHER_LIST, KEDA_SERVICE_MIN_TLS_VERSION and KEDA_SERVICE_TLS_CIPHER_LIST env vars#842
Open
joelsmith wants to merge 1 commit intokedacore:mainfrom
Open
Deploy with KEDA_HTTP_TLS_CIPHER_LIST, KEDA_SERVICE_MIN_TLS_VERSION and KEDA_SERVICE_TLS_CIPHER_LIST env vars#842joelsmith wants to merge 1 commit intokedacore:mainfrom
joelsmith wants to merge 1 commit intokedacore:mainfrom
Conversation
6 tasks
wozniakjan
requested changes
Apr 22, 2026
Member
wozniakjan
left a comment
There was a problem hiding this comment.
the PR check failure is imho related to the changes
Run helm install keda ./keda/ --namespace keda --values test-values.yaml --wait
helm install keda ./keda/ --namespace keda --values test-values.yaml --wait
shell: /usr/bin/bash -e {0}
Error: INSTALLATION FAILED: Service "keda-operator-metrics-apiserver" is invalid: [spec.ports[0].port: Invalid value: 0: must be between 1 and 65535, inclusive, spec.ports[0].targetPort: Invalid value: 0: must be between 1 and 65535, inclusive]
Deployment.apps "keda-operator-metrics-apiserver" is invalid: [spec.template.spec.containers[0].ports[0].containerPort: Required value, spec.template.spec.containers[0].livenessProbe.httpGet.port: Invalid value: 0: must be between 1 and 65535, inclusive, spec.template.spec.containers[0].readinessProbe.httpGet.port: Invalid value: 0: must be between 1 and 65535, inclusive]
There was a problem hiding this comment.
Pull request overview
This PR updates the Helm chart to expose new TLS configuration options (min TLS version and cipher suite list) via values and to pass them to KEDA components as environment variables, aligning with kedacore/keda#7617.
Changes:
- Add new values for HTTP TLS cipher lists and service-side TLS settings.
- Inject
KEDA_HTTP_TLS_CIPHER_LIST,KEDA_SERVICE_MIN_TLS_VERSION, andKEDA_SERVICE_TLS_CIPHER_LISTinto the manager and metrics-server Deployments. - Document the new values in the chart README.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
keda/values.yaml |
Adds TLS-related values (but currently introduces a duplicate top-level service: key). |
keda/templates/metrics-server/deployment.yaml |
Passes new TLS env vars to the metrics server container. |
keda/templates/manager/deployment.yaml |
Passes new TLS env vars to the manager/operator container. |
keda/README.md |
Documents newly added configuration values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nd KEDA_SERVICE_TLS_CIPHER_LIST env vars Signed-off-by: Joel Smith <joelsmith@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings for kedacore/keda#7617
Checklist