Pass imagePullSecrets from ImageSpec to Deployments

[madmecodes]

Summary

Propagate imagePullSecrets from ImageSpec to generated Deployments across all four deployment generators (CacheServer, Shard/RootShard, FrontProxy, VirtualWorkspace).

Previously, resources.GetImageSettings() returned imagePullSecrets but all generators discarded them by assigning to _. This fix captures and sets them on the Deployment's PodSpec.

Fixes #181

Propagate imagePullSecrets from component specs to generated Deployments

Changes

• cacheserver/deployment.go: capture and set imagePullSecrets
• utils/shard.go: capture and set imagePullSecrets (covers RootShard and Shard)
• frontproxy/deployment.go: capture and set imagePullSecrets
• virtualworkspace/deployment.go: capture and set imagePullSecrets
• frontproxy/deployment_test.go: add test cases for imagePullSecrets propagation

[kcp-ci-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kcp-ci-bot]

Hi @madmecodes. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[madmecodes]

/kind feature

[kcp-ci-bot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.