normalize dependabot with consistent formatting and explicit schedule#7400
Conversation
karmada-bot
added
the
kind/cleanup
karmada-bot
added
the
size/M
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the project's automated dependency management strategy. By standardizing the update schedule across all ecosystems and introducing support for Go modules, the changes ensure more predictable and manageable dependency updates while safeguarding against potentially disruptive changes in core Kubernetes libraries. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Dependabot configuration to run dependency update checks on a consistent weekly cadence and to start tracking Go module updates (with exclusions for Kubernetes-related modules).
Changes:
- Standardized
github-actionsanddockerDependabot schedules to run weekly on Mondays at 00:00 UTC. - Added
gomodDependabot updates for the repo root withvendor: true. - Added ignore rules for Kubernetes-related Go modules (
k8s.io/*,sigs.k8s.io/*).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request standardizes Dependabot update schedules to Mondays at 00:00 UTC and introduces the gomod package ecosystem with exclusions for Kubernetes-related dependencies. Feedback suggests reordering the configuration to group identical package ecosystems together for better readability and maintainability.
RainbowMango
force-pushed
the
pr_config_dependabot_for_gomod
branch
2 times, most recently
from
e1c8d20 to
73f7785
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7400 +/- ##
=======================================
Coverage 42.16% 42.17%
=======================================
Files 875 875
Lines 53618 53618
=======================================
+ Hits 22610 22612 +2
+ Misses 29309 29308 -1
+ Partials 1699 1698 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/hold |
karmada-bot
added
the
do-not-merge/hold
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
RainbowMango
force-pushed
the
pr_config_dependabot_for_gomod
branch
from
73f7785 to
93c28e7
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RainbowMango
changed the title
RainbowMango
changed the title
|
/hold cancel |
karmada-bot
removed
the
do-not-merge/hold
|
Try friendly ping @liangyuanpeng as the bot recommends you for approval. :) |
RainbowMango
added
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This pull request updates the Dependabot configuration to specify the exact day, time, and timezone for automated dependency checks. Now, all scheduled updates will consistently run every Monday at 00:00 UTC.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I'm hesitant to let Dependabot manage the Go dependencies, as most of them are shared with Kubernetes dependencies, and bumping them might break compatibility.
So, this PR only formats the configuration and sets an explicit schedule.
Does this PR introduce a user-facing change?: