[AzureAD] Refactor to rely on userdata_from_id_token#796
Draft
consideRatio wants to merge 2 commits into
Draft
Conversation
This fix is only be relevant when `userdata_from_id_token` is True.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I observed that AzureAD's custom functionality seems to be what we have if we configure
userdata_from_id_tokento True, so this PR is simply removing custom functionality and declaringuserdata_from_id_tokento True.This is built on top of #795 for now, which I figure make sense to merge first.