Forward cleanup_kc through execute#350
Draft
sapunyangkut wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cleanup_kcoption to the top-levelexecuteconvenience functionNotebookClient.executeinstead of the constructorNoneRoot cause
The convenience wrapper accepted
cleanup_kcthrough**kwargs, so it passed the option toNotebookClient(...).cleanup_kcbelongs to execution, not construction, and Traitlets rejected it before execution began.Impact
Callers that provide a kernel manager can now explicitly request or suppress cleanup through the convenience API. Existing calls keep their current ownership-based default.
AI disclosure
🤖🍆 This change and pull request description were prepared with OpenAI Codex-assisted automation. Codex modified
nbclient/client.pyandtests/test_client.pyfor this contribution.Fixes #348.