Centralize app cleanup - #792
Conversation
|
Should hopefully pass now that |
23e3288 to
a48e2f5
Compare
7c62a6d to
726948f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
==========================================
+ Coverage 69.96% 70.00% +0.04%
==========================================
Files 62 62
Lines 7368 7355 -13
Branches 1223 1225 +2
==========================================
- Hits 5155 5149 -6
+ Misses 1841 1835 -6
+ Partials 372 371 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Wow, this is awesome. So much cleaner than before. Thank you, @blink1073! |
|
Great stuff. |
|
@meeseeksmachine please backport to 1.x. |
|
@meeseeksdev please backport to 1.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Potentially fixes #790
Depends on jupyter/jupyter_client#772
TODO:
stop_extensionjp_cleanup_subprocessesjupyter_clientwith Fix shutdown and cleanup behavior jupyter/jupyter_client#772