Conversation
Bump grpcio 1.83.0 → 1.83.1, grpcio-reflection 1.74.0 → 1.83.1, protobuf 6.31.1 → 7.36.1, googleapis-common-protos 1.70.0 → 1.75.3. Fix shell_test.py to pass grpc.aio.Metadata() instead of None for AioRpcError initial_metadata/trailing_metadata parameters. The constructor requires Metadata objects; passing None worked at runtime but fails stricter type checking.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe test now passes empty ChangesRPC test update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This PR updates dependencies and corrects test metadata construction without introducing an actionable production or test-path risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the RPC trail Comment |
mangelajo
changed the title
mangelajo
changed the title
mangelajo
added a commit
that referenced
this pull request
Sep 15, 2026
- qdl/driver.py: fix import sorting (I001), reduce complexity of _prepare_cached_flash and _stream_to_tar by extracting helpers (_clear_cache, _try_cache_hit, _collect_source_metadata, _flush_tar_buffer) - qdl/schema.py: fix line too long in _parse_step (E501) - shell_test.py: pass grpc.aio.Metadata() instead of None for AioRpcError initial/trailing_metadata (same fix as PR #1087) - client/base.py: guard close() against missing 'stack' attribute to prevent PytestUnraisableExceptionWarning on Python 3.14 when objects are created via object.__new__() in tests Co-authored-by: Cursor <cursoragent@cursor.com>
mangelajo
added a commit
that referenced
this pull request
Sep 15, 2026
- qdl/driver.py: fix import sorting (I001), reduce complexity of _prepare_cached_flash and _stream_to_tar by extracting helpers (_clear_cache, _try_cache_hit, _collect_source_metadata, _flush_tar_buffer) - qdl/schema.py: fix line too long in _parse_step (E501) - client/base.py: guard close() against missing 'stack' attribute to prevent PytestUnraisableExceptionWarning on Python 3.14 when objects are created via object.__new__() in tests Note: type-check-python failure (shell_test.py AioRpcError Metadata types) is a pre-existing issue caused by the ty type checker getting stricter -- not by library changes. PR #1087 addresses this properly. Co-authored-by: Cursor <cursoragent@cursor.com>
mangelajo
added a commit
that referenced
this pull request
Sep 15, 2026
- qdl/driver.py: fix import sorting (I001), reduce complexity of _prepare_cached_flash and _stream_to_tar by extracting helpers (_clear_cache, _try_cache_hit, _collect_source_metadata, _flush_tar_buffer) - qdl/schema.py: fix line too long in _parse_step (E501) - client/base.py: guard close() against missing 'stack' attribute to prevent PytestUnraisableExceptionWarning on Python 3.14 when objects are created via object.__new__() in tests Note: type-check-python failure (shell_test.py AioRpcError Metadata types) is a pre-existing issue caused by the ty type checker getting stricter -- not by library changes. PR #1087 addresses this properly. Co-authored-by: Cursor <cursoragent@cursor.com>
bkhizgiy
approved these changes
Sep 15, 2026
Member
Author
|
thank you! |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Targeted dependency update for gRPC-related packages and a preventive type fix in
shell_test.py.Changes
Dependency updates (
uv.lock)grpcio1.83.0 → 1.83.1grpcio-reflection1.74.0 → 1.83.1protobuf6.31.1 → 7.36.1googleapis-common-protos1.70.0 → 1.75.3Type fix (
shell_test.py)grpc.aio.Metadata()instead ofNoneforAioRpcErrorinitial_metadata/trailing_metadataparameters.Metadataobjects;Noneworked at runtime but fails under stricter type checking (e.g. when the type checker or stubs are upgraded).Context
Discovered while rebasing #1080 — the
uv.lockconflict resolution triggered a full lock regeneration which upgraded transitive deps and surfaced this latent type issue. This PR applies the fix proactively so future lock refreshes don't break CI."