Skip to content

Refactor script.js to use modern ES6 syntax #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pravintargaryen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor script.js to use modern ES6 syntax #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ $(function() {
});
});

function makeGraph(data, id) {
const makeGraph = (data, id) => {
nv.addGraph(function() {
var chart = nv.models.linePlusBarChart()
let chart = nv.models.linePlusBarChart()
.margin({bottom: 80, left: 60, right: 60})
.focusEnable(false)
.x(function(d,i) {return new Date(d[0])})
Expand All @@ -33,7 +33,7 @@ function makeGraph(data, id) {
chart.y2Axis.tickFormat(d3.format(',f')).showMaxMin(false);
chart.bars.forceY([0]);

var chartData = d3.select(id)
let chartData = d3.select(id)
.append("svg")
.datum(data)
.transition()
Expand All @@ -46,10 +46,10 @@ function makeGraph(data, id) {
});
}

function processData(rows, title) {
var bar_data = [], line_data = [];
for(var i = 0; i < rows.length; i++) {
var row = rows[i];
const processData = (rows, title) => {
let bar_data = [], line_data = [];
for(let i = 0; i < rows.length; i++) {
let row = rows[i];
bar_data.push([row["date"], parseFloat(row["value"])]);
line_data.push([row["date"], parseFloat(row["cumulative"])]);
}
Expand Down