Use saturating arithmetic as we march along an active edge.#108
Open
pcwalton wants to merge 1 commit into
Open
Use saturating arithmetic as we march along an active edge.#108pcwalton wants to merge 1 commit into
pcwalton wants to merge 1 commit into
Conversation
Fixes jrmuizel#107, but I'm not sure this is the best fix.
Owner
|
I'm also not sure this is best fix. Right now raqote doesn't deal very well with large coordinates and I think it needs a more disciplined approach. That begins said, I'm not sure what that approach will look like yet. FWIW, Skia clips edges to the bounds/clip before inserting them. This would work, but it's a little more elaborate and has the problem that changing the bounds can change the rasterization because rasterizing the clipped edge may not give exactly the same results as the original edge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107, but I'm not at all sure this is the best fix.