Skip to content

Fix \temporal typo (#224)#225

Closed
cfr42 wants to merge 4 commits into
mainfrom
fix-temporal-typo
Closed

Fix \temporal typo (#224)#225
cfr42 wants to merge 4 commits into
mainfrom
fix-temporal-typo

Conversation

@cfr42

@cfr42 cfr42 commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

Describe the change and why it is needed

Checklist

  • Code follows the standard expl3 style including no lines longer
    than 79 chars
  • There is a ChangeLog entry
  • There is a linked issue (not needed for trivial PRs, e.g. fixing
    typos)
  • l3build ctan passes

@cfr42 cfr42 marked this pull request as ready for review June 14, 2026 05:19
@cfr42 cfr42 closed this Jun 14, 2026
@cfr42 cfr42 deleted the fix-temporal-typo branch June 14, 2026 20:18
@cfr42

cfr42 commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator Author

something like

\int_new:N \l_@@_tmpa_int
\str_new:N \l_@@_tmpa_seq
\NewDocumentCommand \temporal { D <> { all } +m +m +m }
  {
    \@@_if_overlay:nTF {#1}
      {#3}
      {
        \int_if_exist:cF {g_@@_temporal_\tl_to_str:n {#1}_max_int}
          {
            \int_new:c {g_@@_temporal_\tl_to_str:n {#1}_max_int}
            \int_set:Nn \l_@@_tmpa_int {0}
            \clist_map_inline:Nn \l_@@_decode_overlays_clist 
              {
                \seq_set_split:Nnn \l_@@_tmpa_seq {-} {##1}
                \int_compare:nNnT 
                  {\seq_item:Nn \l_@@_tmpa_seq {-1}} > {\l_@@_tmpa_int}
                  {
                    \int_set_eq:NN \l_@@_tmpa_int 
                      {\seq_item:Nn \l_@@_tmpa_seq {-1}}
                  }
              }
              \int_gset_eq:cN 
                {g_@@_temporal_\tl_to_str:n {#1}_max_int} \l_@@_tmpa_int
          }
        \int_compare:vNnTF 
          {g_@@_temporal_\tl_to_str:n {#1}_max_int} < {\g_@@_slide_int}
          {
            #4
          } {
            \bool_if:NTF \g_@@_slide_continue_bool
              {#2}
              {
                #4
              }
          }
      }
  }

@cfr42 cfr42 reopened this Jun 14, 2026
@cfr42 cfr42 marked this pull request as draft June 14, 2026 23:49
@josephwright

Copy link
Copy Markdown
Owner

I've fixed at the decode level, so closing here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants