fix(helm): allow setting a storage class for the built-in Postgres PVC - #577
Merged
Merged
Conversation
The postgres-data PVC omitted storageClassName entirely, so it always relied on the cluster providing a default StorageClass. On clusters without one — e.g. EKS, where neither gp2 nor gp3 is marked default — the PVC stays Pending indefinitely, Postgres never starts, and the API crash-loops with no obvious cause. Add postgresql.storage.storageClass, mirroring the existing installedSkillsCache.storageClass and agent.pvc.storageClass pattern. Leaving it empty (the default) omits the field, preserving the current cluster-default behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The postgres-data PVC omitted storageClassName entirely, so it always relied on the cluster providing a default StorageClass. On clusters without one — e.g. EKS, where neither gp2 nor gp3 is marked default — the PVC stays Pending indefinitely, Postgres never starts, and the API crash-loops with no obvious cause.
Add postgresql.storage.storageClass, mirroring the existing installedSkillsCache.storageClass and agent.pvc.storageClass pattern. Leaving it empty (the default) omits the field, preserving the current cluster-default behaviour.
Testing
pnpm turbo test)pnpm turbo typecheck)