feat: add PDF mime type to enable native file selection#1664
Open
GabrielBaiano wants to merge 1 commit intojohnfactotum:gtk4from
Open
feat: add PDF mime type to enable native file selection#1664GabrielBaiano wants to merge 1 commit intojohnfactotum:gtk4from
GabrielBaiano wants to merge 1 commit intojohnfactotum:gtk4from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables PDF files to be recognized and selected naturally within Foliate, and ensures the application is associated with PDF files at the system level.
Changes:
application/pdfto theGtk.FileFilterin the "Open" and "Add" dialogs. This allows users to browse and select PDF files directly from the internal file chooser.application/pdfto theMimeTypefield, so desktop environments can suggest Foliate as a PDF viewer.Motivation and Context
Foliate already supports rendering PDFs via PDF.js, but they were missing from the file filters and were not registered in the desktop entry. This change synchronizes the app's internal logic and system metadata with its actual capabilities.