added perfect black background for amoled display#1636
added perfect black background for amoled display#1636sudheeshpoolakkal wants to merge 1 commit intojohnfactotum:gtk4from
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds a new "Perfect Black" theme optimized for AMOLED displays with pure black (#000000) background to save power on OLED screens. The PR also includes a minor code formatting improvement to the invertTheme function for better readability.
Changes:
- Added "Perfect Black" theme with pure black background (#000000) for AMOLED displays
- Reformatted
invertThemefunction to improve code readability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| { | ||
| name: 'perfect-black', label: _('Perfect Black'), | ||
| light: { fg: '#cccccc', bg: '#000000', link: '#77bbee' }, |
There was a problem hiding this comment.
The "Perfect Black" theme is designed for AMOLED displays with a pure black background (#000000), but it uses identical values for both light and dark modes. This is unusual compared to all other themes in the codebase, which have distinct light and dark variants.
For a theme optimized for AMOLED displays in dark mode, the light variant should likely use a more traditional light color scheme (light background, dark foreground) similar to other themes. For example, you could use something like: light: { fg: '#000000', bg: '#ffffff', link: '#0066cc' } to provide a proper light mode experience while keeping the AMOLED-optimized pure black for dark mode.
| light: { fg: '#cccccc', bg: '#000000', link: '#77bbee' }, | |
| light: { fg: '#000000', bg: '#ffffff', link: '#0066cc' }, |
No description provided.