feat: Add intelligent "Meaning" tool with dictionary/translation auto-detection#1578
Open
nov3o wants to merge 1 commit intojohnfactotum:gtk4from
Open
feat: Add intelligent "Meaning" tool with dictionary/translation auto-detection#1578nov3o wants to merge 1 commit intojohnfactotum:gtk4from
nov3o wants to merge 1 commit intojohnfactotum:gtk4from
Conversation
Owner
|
It's not clear to me what use case this would be advantageous for. Perhaps if you need to switch back and forth between different tools. It used to have a "tabbed" design like this, together with the Wikipedia tool, which is similar to the design used by Kindle. But I think the current design does have some advantage in its simplicity. As for the implementation, for a design like this one it would probably be better to use the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
• Replace separate Dictionary/Translate tools with unified "Meaning" tool
• Auto-detect: single words → Dictionary, phrases → Translation
• Fallback: Dictionary lookup fails → Translation mode available with language selection
• Manual switching with Dictionary/Translate tabs