Skip to content

Add "Books" to list of keywords in .desktop file#1566

Open
johnlorentzson wants to merge 1 commit intojohnfactotum:gtk4from
johnlorentzson:books-keyword
Open

Add "Books" to list of keywords in .desktop file#1566
johnlorentzson wants to merge 1 commit intojohnfactotum:gtk4from
johnlorentzson:books-keyword

Conversation

@johnlorentzson
Copy link
Copy Markdown

Perhaps changing the "book" keyword that exists would be the better move. I don't mind either way, I just want to be able to type "books" into a system search and get books.

@johnfactotum
Copy link
Copy Markdown
Owner

Adding it is fine, I guess. But perhaps one would need to fix all the translations as well. That is, to replace all the current instances of Ebook;Book;EPUB;Viewer;Reader; in the .po files with Ebook;Book;Books;EPUB;Viewer;Reader;, to avoid disrupting the translations. Otherwise the keywords would stop being translated until they are each fixed by a translator, which might take a long time.

@djinnalexio
Copy link
Copy Markdown

to replace all the current instances of Ebook;Book;EPUB;Viewer;Reader;

Do you mean just doing a Find/Replace on all the po files and let translators update the translation later? If so, it's quickly done.

Also, I'm proposing this:

- Keywords=Ebook;Book;EPUB;Viewer;Reader;
+ Keywords=ebooks;books;epub;ereader;reader;viewer;library;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants