Use external @poleski/quality-tools package#211
Draft
joesobo wants to merge 5 commits into
Draft
Conversation
|
Owner
Author
|
Update pushed: finished the monorepo bridge cleanup and validation.
Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/quality-toolsimplementation and root Stryker config.@poleski/quality-toolsas a local linked dev dependency for pre-publish integration testing.quality-toolsCLI.QUALITY_TOOLS_*and update quality docs for the external ownership model.Validation
pnpm installpnpm --filter @codegraphy/extension run typecheckpnpm run typecheck(all 9 workspace packages passed)pnpm exec quality-tools --helppnpm run organize -- extension/src/shared --jsonpnpm run reachability -- extension/src/shared/visibleGraphpnpm --filter @codegraphy/extension exec vitest run --config vitest.config.ts tests/vitest.includes.test.tsHandoff Before Merge
This PR intentionally uses
"@poleski/quality-tools": "link:../quality-tools/packages/quality-tools"so we can test the split locally before publishing. After@poleski/quality-toolsis published, replace the link with the published semver range, runpnpm install, and rerun the quality script smoke checks before merging.Known Signal
pnpm run boundaries -- extension/src/shared/visibleGraphreaches the external CLI but fails on the current extension-wide boundary signal:packages/extension/src/webview/pluginHost/api/contracts/webview.ts [webview] -> packages/extension/src/core/plugins/disposable.ts [core]. I left that unrelated architecture issue untouched.