Skip to content

Use external @poleski/quality-tools package#211

Draft
joesobo wants to merge 5 commits into
mainfrom
codex/external-quality-tools
Draft

Use external @poleski/quality-tools package#211
joesobo wants to merge 5 commits into
mainfrom
codex/external-quality-tools

Conversation

@joesobo
Copy link
Copy Markdown
Owner

@joesobo joesobo commented May 20, 2026

Summary

  • Remove the in-monorepo packages/quality-tools implementation and root Stryker config.
  • Add @poleski/quality-tools as a local linked dev dependency for pre-publish integration testing.
  • Route the root quality scripts through the external quality-tools CLI.
  • Rename CodeGraphy-specific Vitest env vars to QUALITY_TOOLS_* and update quality docs for the external ownership model.

Validation

  • pnpm install
  • pnpm --filter @codegraphy/extension run typecheck
  • pre-commit pnpm run typecheck (all 9 workspace packages passed)
  • pnpm exec quality-tools --help
  • pnpm run organize -- extension/src/shared --json
  • pnpm run reachability -- extension/src/shared/visibleGraph
  • pnpm --filter @codegraphy/extension exec vitest run --config vitest.config.ts tests/vitest.includes.test.ts

Handoff Before Merge

This PR intentionally uses "@poleski/quality-tools": "link:../quality-tools/packages/quality-tools" so we can test the split locally before publishing. After @poleski/quality-tools is published, replace the link with the published semver range, run pnpm install, and rerun the quality script smoke checks before merging.

Known Signal

pnpm run boundaries -- extension/src/shared/visibleGraph reaches the external CLI but fails on the current extension-wide boundary signal: packages/extension/src/webview/pluginHost/api/contracts/webview.ts [webview] -> packages/extension/src/core/plugins/disposable.ts [core]. I left that unrelated architecture issue untouched.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 20, 2026

⚠️ No Changeset found

Latest commit: fd406ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joesobo
Copy link
Copy Markdown
Owner Author

joesobo commented May 20, 2026

Update pushed: finished the monorepo bridge cleanup and validation.

  • Removed the stale root tsconfig.json reference to packages/quality-tools.
  • Isolated pipeline/rules.test.ts from user-local installed plugin state so the extension suite is deterministic.
  • Legacy internal quality-tools audit now only finds the intentional local link:../quality-tools/packages/quality-tools dependency entries.

Validation:

  • pnpm --filter @codegraphy/extension exec vitest run --config vitest.config.ts tests/extension/pipeline/rules.test.ts passed.
  • pnpm run typecheck passed.
  • pnpm run lint passed.
  • pnpm run crap -- extension/ ran through the linked external package, passed 868/868 Vitest files and 5433/5433 tests, then reported 34 functions above the configured CRAP threshold of 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant