Skip to content

Fix ktlint violation in JsonMessage.kt - #1309

Merged
bgrozev merged 1 commit into
masterfrom
claude/fix-ktlint-jsonmessage
Aug 25, 2026
Merged

Fix ktlint violation in JsonMessage.kt#1309
bgrozev merged 1 commit into
masterfrom
claude/fix-ktlint-jsonmessage

Conversation

@bgrozev

@bgrozev bgrozev commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

  • #1308 added toString() overrides in JsonMessage.kt that trip ktlint's rule requiring a single-line expression body to stay on the function signature line, breaking CI on master
  • Reformat the two toString() overrides to satisfy ktlint (ran ktlint-maven-plugin:format)

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.86%. Comparing base (9c814ab) to head (ae51d1c).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...c/main/kotlin/org/jitsi/jicofo/xmpp/JsonMessage.kt 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1309      +/-   ##
==========================================
- Coverage   52.88%   52.86%   -0.02%     
==========================================
  Files         133      133              
  Lines        8511     8514       +3     
  Branches     1293     1296       +3     
==========================================
  Hits         4501     4501              
- Misses       3384     3387       +3     
  Partials      626      626              
Files with missing lines Coverage Δ
...c/main/kotlin/org/jitsi/jicofo/xmpp/JsonMessage.kt 88.63% <0.00%> (-6.49%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a922a3...ae51d1c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jitsi-ci Bot pushed a commit to jitsi/jitsi-pr-tests-pages that referenced this pull request Aug 25, 2026
@bgrozev
bgrozev merged commit 50076cb into master Aug 25, 2026
3 of 6 checks passed
@bgrozev
bgrozev deleted the claude/fix-ktlint-jsonmessage branch August 25, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants