Skip to content

Add jibri_no_instance_failures metric - #1306

Merged
bgrozev merged 1 commit into
masterfrom
jit-15961-jibri-no-instance-metric
Aug 19, 2026
Merged

Add jibri_no_instance_failures metric#1306
bgrozev merged 1 commit into
masterfrom
jit-15961-jibri-no-instance-metric

Conversation

@bgrozev

@bgrozev bgrozev commented Aug 19, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds a new counter, jibri_no_instance_failures, incremented only when a jibri session fails to start because no instance was available (StartException.NotAvailable).
  • Existing per-type failure counters (jibri_sip_failures, jibri_recording_failures, jibri_live_streaming_failures) increment for all failure reasons and cannot isolate this case.

Distinguishes jibri start failures caused by no instance being
available from other failure types, which were previously all
lumped into the generic per-type failure counters.
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.43%. Comparing base (e98ec08) to head (f03b5cb).

Files with missing lines Patch % Lines
...main/java/org/jitsi/jicofo/jibri/JibriSession.java 0.00% 1 Missing and 1 partial ⚠️
...c/main/kotlin/org/jitsi/jicofo/jibri/JibriStats.kt 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1306      +/-   ##
==========================================
- Coverage   51.43%   51.43%   -0.01%     
==========================================
  Files         132      132              
  Lines        8451     8457       +6     
  Branches     1289     1290       +1     
==========================================
+ Hits         4347     4350       +3     
- Misses       3494     3496       +2     
- Partials      610      611       +1     
Files with missing lines Coverage Δ
...c/main/kotlin/org/jitsi/jicofo/jibri/JibriStats.kt 81.48% <75.00%> (-1.13%) ⬇️
...main/java/org/jitsi/jicofo/jibri/JibriSession.java 38.99% <0.00%> (-0.31%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e98ec08...f03b5cb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jitsi-ci Bot pushed a commit to jitsi/jitsi-pr-tests-pages that referenced this pull request Aug 19, 2026
@bgrozev
bgrozev merged commit 7ebb13d into master Aug 19, 2026
5 of 6 checks passed
@bgrozev
bgrozev deleted the jit-15961-jibri-no-instance-metric branch August 19, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants