Skip to content

Cache autoupdate check to run only once per 24 hours #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
murataslan1 wants to merge 2 commits into
base: dev
Choose a base branch
from
+13 −1
Open

Cache autoupdate check to run only once per 24 hours #2276

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d40eee
Cache autoupdate check to run only once per 24 hours
murataslan1 Nov 29, 2025
a7eb97c
Make update check interval configurable
murataslan1 Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/main/electron.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,8 +1171,18 @@ app.whenReady().then(() =>
owner: 'jgraph'
})

if (store == null || (!disableUpdate && !store.get('dontCheckUpdates')))
// Cache update check - only check once per 24 hours to avoid repeated messages
const UPDATE_CHECK_INTERVAL = 24 * 60 * 60 * 1000; // 24 hours
Copy link
Copy Markdown

@andrei-melnikau-plateau andrei-melnikau-plateau Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this UPDATE_CHECK_INTERVAL configurable. Hardcoding 24h looks like a kludge. What if I want to check once per week?

const lastUpdateCheck = store?.get('lastUpdateCheck') || 0;
const shouldCheckUpdates = Date.now() - lastUpdateCheck > UPDATE_CHECK_INTERVAL;

if (store == null || (!disableUpdate && !store.get('dontCheckUpdates') && shouldCheckUpdates))
{
if (store != null)
{
store.set('lastUpdateCheck', Date.now());
}

autoUpdater.checkForUpdates()
}
})
Expand Down