Skip to content

Auto-Update check not working #2454

Open

Description

@moha-gh

Describe the bug

After contributing some fixes for the auto-updater a while ago, I was wondering why I'm not being notified about new releases by lazygit itself.

The log reports:

Feb 20 06:56:56 |INFO| Binary is not built with the buildBinary flag so we won't check for an update

After briefly checking the source code, I think there is a mismatch between the build source set for the release here, i.e. binaryRelease and the check being done here, i.e. for buildBinary.

If this turns out to actually be the root cause, I'd be happy to file a PR to fix the issue - but I'd need some guidance on which side to change. Adapting the releaser config might unblock auto-updates for previously released versions in the field. Adapting the updater code looks cleaner to me (binaryRelease sounds like a better build type choice than buildBinary). I'd also be nice to only define this value in one place and refer it in both the config and the code to avoid future issues - if it ever changes again.

To Reproduce

Start lazygit and check logs.

Expected behavior

Notification about new release (0.37.0 at time of writing) is shown.

Screenshots

n/a

Version info:

commit=d1a8b05401ccda1e52215203139a252eb3be3b79, build date=2022-11-14T09:22:31Z, build source=binaryRelease, version=0.36.0, os=linux, arch=amd64, git version=2.39.2

Additional context

n/a

Activity

  1. socketbox commented on Apr 4, 2023

    @socketbox
    Sponsor

    @moha-gh is the notification feature something that needs to be configured? I was running c4e71356 (released 2022-10-25) and did not receive a notification of a newer version. When I ran the following:

    cd ~/go
    go install  github.com/jesseduffield/lazygit@latest
    lazygit -v
    

    I got back some disconcertingly uninformative version info:
    commit=, build date=, build source=unknown, version=unversioned, os=linux, arch=amd64, git version=2.40.0

    I realize that this isn't germane to the issue you've opened, but what have I done wrong?

  2. moha-gh commented on Apr 5, 2023

    @moha-gh
    ContributorAuthor

    @socketbox : In general, the update notifications are supposed to work out-of-the-box. For releases downloaded directly from GitHub that's broken (which is the issue I filed this ticket for).

    In your case, the update check also won't work, bailing out one step earlier than for my setup.

    I'd guess that whatever you get when installing lazygit using go install is different to what you get when you download and "install" the releases from GitHub. Since it misses build and version information, it's kind of impossible for the updater to work... It might be worth filing an additional ticket for your issue - I have no idea whether the missing information is expected when using 'go install' - or a bug.

  3. stevenlele commented on Nov 9, 2026

    @stevenlele

    @stefanhaller Could you take a look at this issue? Should be an easy fix as shown in #6161.

  4. stefanhaller commented on Nov 9, 2026

    @stefanhaller
    Collaborator

    @stevenlele No, this is not an easy fix; patching only this one problem would make things rather worse than better, because the auto-update mechanism is broken in many other ways. I'm working on a complete reimplementation of all this to make it work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions