Fix MCP optimization sessions failing to load in the dashboard#586
Merged
Conversation
create_optimization_draft_service persisted an incomplete session results state ({alert}
only). The dashboard's loadSession patches that state in and then reads
results.progressbar.current / results.exception.error directly, so MCP-created sessions
crashed with 'Failed to load session' (dashboard-run ones work because the store is
pre-filled). Persist the COMPLETE results shape, matching dashboard-v1 optimizationStore.ts.
Pairs with the dashboard-v1 guard PR (which also recovers already-saved broken sessions).
The dashboard must be rebuilt into jesse/static at release.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP optimization draft persisted an incomplete
resultsstate ({alert}only). The dashboard'sloadSession$patches that state and then readsresults.progressbar.current/results.exception.errordirectly → MCP-created sessions crashed with Failed to load session (dashboard-run ones work because the store is pre-filled). This persists the complete results shape (matching dashboard-v1optimizationStore.tsstate()).Pairs with dashboard-v1 PR (the
_ensureResultsShapeguard, which also recovers already-saved broken sessions). The dashboard must be rebuilt intojesse/staticat release.🤖 Generated with Claude Code