Skip to content

fix: sportbugs

62ceadf
Select commit
Loading
Failed to load commit list.
Closed

feat: new launcher using Apache Mina sshd library #570

fix: sportbugs
62ceadf
Select commit
Loading
Failed to load commit list.
ci.jenkins.io / Open Tasks Scanner succeeded Jul 9, 2025

33 new issues, 36 total

Total New Outstanding Fixed Trend
36 33 3 0 👎

Reference build: Plugins » ssh-agents-plugin » main #126

Details

Severity distribution of new issues

Error Warning High Warning Normal Warning Low
0 12 21 0

Annotations

Check warning on line 47 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/Connection.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

FIXME

HIGH:
The remote file should be relative to the working directory.

Check warning on line 48 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/Connection.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

FIXME

HIGH:
use SHA instead of MD5 to check the content of the file, it is no longer in the JDK.

Check warning on line 11 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/KnownHosts.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
Implement a proper host key verification mechanism.

Check warning on line 8 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/ServerHostKeyVerifier.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
Implement a proper host key

Check warning on line 13 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/ShellChannel.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
review names for interactive and non-interactive sessions. Mina uses ShellChannel for interactive and ExecChannel for non-interactive.

Check warning on line 59 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/ConnectionImpl.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
implement the host key verifier

Check warning on line 82 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/ConnectionImpl.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
implement the working directory

Check warning on line 105 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/ConnectionImpl.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

FIXME

HIGH:
review, it does not return the exit code as it is said in the javadoc

Check warning on line 153 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/ConnectionImpl.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
set access/modification time to be the same as the source

Check warning on line 156 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/ConnectionImpl.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
document the permissions the file needs and how to set the umask

Check warning on line 157 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/ConnectionImpl.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
verify if the file exists and if the content is the same

Check warning on line 158 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/ConnectionImpl.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
verify if the file is a directory

Check warning on line 181 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/ConnectionImpl.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

FIXME

HIGH:
send these logs to the TaskListener of the computer launcher

Check warning on line 220 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/ConnectionImpl.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

FIXME

HIGH:
send these logs to the TaskListener of the computer launcher

Check warning on line 235 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/ConnectionImpl.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
set the host verifier

Check warning on line 332 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/ConnectionImpl.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

FIXME

HIGH:
rename for Stderr

Check warning on line 339 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/ConnectionImpl.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

FIXME

HIGH:
rename to Stdout

Check warning on line 13 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/KeyAlgorithmManagerImpl.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:

Check warning on line 399 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/SSHApacheMinaLauncher.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
review if it is needed or move to the SSH Provider.

Check warning on line 405 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/SSHApacheMinaLauncher.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
Seems we need to retrieve the encoding from the connection destination

Check warning on line 509 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/SSHApacheMinaLauncher.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
implement verifiers.

Check warning on line 936 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/SSHApacheMinaLauncher.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
review if the HostnamePortRequirement is really needed

Check warning on line 974 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/SSHApacheMinaLauncher.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
review if the HostnamePortRequirement is really needed

Check warning on line 1035 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/SSHApacheMinaLauncher.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
think about to improve the way we process the Java path

Check warning on line 1051 in src/main/java/io/jenkins/plugins/sshbuildagents/ssh/mina/SSHApacheMinaLauncher.java

See this annotation in the file changed.

@ci-jenkins-io ci-jenkins-io / Open Tasks Scanner

TODO

NORMAL:
add a connection verifier