Allow exclusions to be specified at the start of the branch name - #46
Closed
atwright wants to merge 1 commit into
Closed
Allow exclusions to be specified at the start of the branch name#46atwright wants to merge 1 commit into
atwright wants to merge 1 commit into
Conversation
Member
|
This is linked to JENKINS-42657 Good catch 👍 |
Member
|
It's good also for me (a really wanted fix) |
Member
|
superseded by #53 |
Member
|
@atwright Could you check that this fix is not required in https://github.com/jenkinsci/scm-api-plugin/pull/36/files#diff-f03c7c17b4861f933d5a12faa8bd2a07R114 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all - we were trying to setup some includes within BitBucket to only scan particular branches in a repo and came across what looks like a small bug. The code in getPattern() was prepending a .* to the second and subsequent patterns in the input.
Eg, input of:
master branchwould result in trying to match:
master *branchwhich would then incorrectly match a branch name of:
TEST-branchwhereas we only would expect it to match:
branchin that case.
Note that the visibility change on isExcluded is just for the purposes of testing - not required for the actual fix.
See what you think, happy to discuss or change if you'd like more info.
Kind regards,
Andrew