Cleanup for carrot_core#5
Merged
jeffro256 merged 3 commits intojeffro256:carrot_corefrom Apr 8, 2026
Merged
Conversation
UkoeHB
force-pushed
the
carrot_core_cleanup
branch
from
7c85294 to
78363ed
Compare
UkoeHB
force-pushed
the
carrot_core_cleanup
branch
from
78363ed to
3528738
Compare
Author
|
CI error with Arch Linux finding Boost, seems unrelated. |
jeffro256
requested changes
Apr 8, 2026
Owner
jeffro256
left a comment
jeffro256
left a comment
There was a problem hiding this comment.
Thank you so much for reviewing!! Largely agree with the changes, just have a few comments.
jeffro256
reviewed
Apr 8, 2026
Co-authored-by: Jeffro <jeffro256@tutanota.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly comments and a couple function renames for consistency/accuracy. Removed references to Seraphis.
Will approve monero-project#9559 once this is merged.