Skip to content

feat: add support for mj-html-attributes, mj-selector, and mj-html-attribtue #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codedninja wants to merge 2 commits into
base: main
Choose a base branch
from

Added and fixed tests for mj-html-attributes, mj-selector, mj-html-at…

314a691
Select commit
Loading
Failed to load commit list.
Open

feat: add support for mj-html-attributes, mj-selector, and mj-html-attribtue #535

Added and fixed tests for mj-html-attributes, mj-selector, mj-html-at…
314a691
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 27, 2026 in 0s

91.33% (-1.56%) compared to 5311e58

View this Pull Request on Codecov

91.33% (-1.56%) compared to 5311e58

Details

Codecov Report

❌ Patch coverage is 73.22721% with 185 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.33%. Comparing base (5311e58) to head (314a691).
⚠️ Report is 201 commits behind head on main.

Files with missing lines Patch % Lines
packages/mrml-core/src/prelude/render/tag.rs 7.44% 87 Missing ⚠️
packages/mrml-core/src/mj_selector/parse.rs 53.33% 28 Missing ⚠️
packages/mrml-core/src/mj_html_attributes/parse.rs 30.30% 23 Missing ⚠️
packages/mrml-core/src/mj_html_attributes/mod.rs 17.64% 14 Missing ⚠️
packages/mrml-core/src/mj_html_attribute/mod.rs 20.00% 12 Missing ⚠️
packages/mrml-core/src/mj_html_attribute/json.rs 71.42% 6 Missing ⚠️
packages/mrml-core/src/mj_hero/render.rs 86.84% 5 Missing ⚠️
packages/mrml-core/src/mj_head/parse.rs 40.00% 3 Missing ⚠️
packages/mrml-core/src/mj_html_attribute/parse.rs 90.90% 3 Missing ⚠️
packages/mrml-core/src/mj_html_attribute/print.rs 85.00% 3 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #535      +/-   ##
==========================================
- Coverage   92.89%   91.33%   -1.56%     
==========================================
  Files         227      213      -14     
  Lines       12203    12869     +666     
==========================================
+ Hits        11336    11754     +418     
- Misses        867     1115     +248

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov