Asn upgrade

.devcontainer/Dockerfile

@@ -12,7 +12,7 @@
 ################################################################
 # Devcontainer Image (for local development and CI)
 ################################################################
-FROM ghcr.io/magma/magma/bazel-base:latest as devcontainer
+FROM ghcr.io/magma/magma/bazel-base:latest AS devcontainer
 
 # [Option] Install zsh
 ARG INSTALL_ZSH="true"
@@ -76,7 +76,8 @@ RUN echo "Install general purpose packages" && \
         ruby-dev \
         software-properties-common \
         tzdata \
-        virtualenv=20.0.17-1ubuntu0.4 && \
+        virtualenv=20.0.17-1ubuntu0.4
+RUN gem install dotenv -v 2.8.1 && \
     gem install fpm
 
 # Install golang

.devcontainer/bazel-base/Dockerfile

@@ -12,7 +12,7 @@
 ################################################################
 # Builder Image (can also be used as developer's image)
 ################################################################
-FROM ubuntu:focal as bazel_builder
+FROM ubuntu:focal AS bazel_builder
 
 ARG DEB_PORT=amd64
 

.devcontainer/post-create-commands.sh

@@ -1,12 +1,16 @@
 #!/bin/bash
-
 # $1: should be containerWorkspaceFolder from https://code.visualstudio.com/docs/remote/devcontainerjson-reference
+if [ "$1" != "$MAGMA_ROOT" ]
+then
+    sudo rm -rf "$MAGMA_ROOT"
+    sudo ln -s "$1" "$MAGMA_ROOT"
+fi
 
-sudo ln -s "$1"/lte/gateway/configs /etc/magma
+sudo ln -s "$MAGMA_ROOT"/lte/gateway/configs /etc/magma
 echo "alias magtivate='source /home/vscode/build/python/bin/activate'" >> ~/.bashrc
 
 echo "Generating compile_commands.json for C/C++ code navigation"
-"$1"/dev_tools/gen_compilation_database.py
+"$MAGMA_ROOT"/dev_tools/gen_compilation_database.py
 
 echo "Setting up Bazel Bash completion"
-"$1"/bazel/scripts/setup_bazel_bash_completion.sh $(cat "$1"/.bazelversion)
+"$MAGMA_ROOT"/bazel/scripts/setup_bazel_bash_completion.sh $(cat "$MAGMA_ROOT"/.bazelversion)

.github/workflows/agw-build-publish-container.yml

@@ -93,24 +93,28 @@ jobs:
         run: |
           c_image=${{ steps.set-registry.outputs.registry }}/${{ steps.set-registry.outputs.image_prefix }}agw_gateway_c
           python_image=${{ steps.set-registry.outputs.registry }}/${{ steps.set-registry.outputs.image_prefix }}agw_gateway_python
+          ovs_image=${{ steps.set-registry.outputs.registry }}/${{ steps.set-registry.outputs.image_prefix }}agw_gateway_ovs
           go_image=${{ steps.set-registry.outputs.registry }}/${{ steps.set-registry.outputs.image_prefix }}gateway_go
 
           echo image_tag=${commit_hash} >> $GITHUB_OUTPUT
           if [[ ${{ github.ref_name }} = master ]]
           then
             echo c_image_tags=${c_image}:${commit_hash},${c_image}:latest >> $GITHUB_OUTPUT
             echo python_image_tags=${python_image}:${commit_hash},${python_image}:latest >> $GITHUB_OUTPUT
+            echo ovs_image_tags=${ovs_image}:${commit_hash},${ovs_image}:latest >> $GITHUB_OUTPUT
             echo go_image_tags=${go_image}:${commit_hash},${go_image}:latest >> $GITHUB_OUTPUT
           else
             echo c_image_tags=${c_image}:${commit_hash} >> $GITHUB_OUTPUT
             echo python_image_tags=${python_image}:${commit_hash} >> $GITHUB_OUTPUT
+            echo ovs_image_tags=${ovs_image}:${commit_hash} >> $GITHUB_OUTPUT
             echo go_image_tags=${go_image}:${commit_hash} >> $GITHUB_OUTPUT
           fi
 
       - name: Print agwc tags
         run: |
           echo "C image: ${{ steps.set-agwc-tags.outputs.c_image_tags }}"
           echo "Python image: ${{ steps.set-agwc-tags.outputs.python_image_tags }}"
+          echo "OVS image: ${{ steps.set-agwc-tags.outputs.ovs_image_tags }}"
           echo "Go image: ${{ steps.set-agwc-tags.outputs.go_image_tags }}"
 
       - uses: ./.github/workflows/composite/docker-builder-agw
@@ -134,6 +138,16 @@ jobs:
           TAGS: ${{ steps.set-agwc-tags.outputs.python_image_tags }}
           TARGET: gateway_python
       - run: echo "docker-builder-python conclusion = ${{ steps.docker-builder-python.conclusion }}"
+      - uses: ./.github/workflows/composite/docker-builder-agw
+        id: docker-builder-ovs
+        with:
+          REGISTRY_USERNAME: ${{ secrets.LF_JFROG_USERNAME }}
+          REGISTRY_PASSWORD: ${{ secrets.LF_JFROG_PASSWORD }}
+          REGISTRY: ${{ env.registry }}
+          FILE: lte/gateway/docker/services/openvswitch/Dockerfile
+          TAGS: ${{ steps.set-agwc-tags.outputs.ovs_image_tags }}
+          TARGET: gateway_ovs
+      - run: echo "docker-builder-ovs conclusion = ${{ steps.docker-builder-ovs.conclusion }}"
 
       - uses: ./.github/workflows/composite/docker-builder-agw
         id: docker-builder-go
@@ -233,35 +247,35 @@ jobs:
         run: mkdir -p lte/gateway/test_results
 
       - name: Download test results of precommit tests
-        uses: actions/download-artifact@9782bd6a9848b53b110e712e20e42d89988822b7 # pin@v3.0.1
+        uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # pin@v4
         with:
           name: test_results_precommit
           path: "${{ github.workspace }}/lte/gateway/test_results"
 
       - name: Download final status of precommit tests
-        uses: actions/download-artifact@9782bd6a9848b53b110e712e20e42d89988822b7 # pin@v3.0.1
+        uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # pin@v4
         with:
           name: test-status-precommit
 
       - name: Download test results of extended tests
-        uses: actions/download-artifact@9782bd6a9848b53b110e712e20e42d89988822b7 # pin@v3.0.1
+        uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # pin@v4
         with:
           name: test_results_extended_tests
           path: "${{ github.workspace }}/lte/gateway/test_results"
 
       - name: Download final status of of extended tests
-        uses: actions/download-artifact@9782bd6a9848b53b110e712e20e42d89988822b7 # pin@v3.0.1
+        uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # pin@v4
         with:
           name: test-status-extended_tests
 
       - name: Download test results of long extended tests
-        uses: actions/download-artifact@9782bd6a9848b53b110e712e20e42d89988822b7 # pin@v3.0.1
+        uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # pin@v4
         with:
           name: test_results_extended_tests_long
           path: "${{ github.workspace }}/lte/gateway/test_results"
 
       - name: Download final status of of long extended tests
-        uses: actions/download-artifact@9782bd6a9848b53b110e712e20e42d89988822b7 # pin@v3.0.1
+        uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # pin@v4
         with:
           name: test-status-extended_tests_long
 

.github/workflows/agw-coverage.yml

@@ -94,7 +94,7 @@ jobs:
         with:
           flags: c_cpp
       - name: Publish bazel profile
-        uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+        uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         if: |
           always() &&
           github.repository_owner == 'magma' &&
@@ -163,7 +163,7 @@ jobs:
         with:
           flags: lte-test
       - name: Publish bazel profile
-        uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+        uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         if: |
           always() &&
           github.repository_owner == 'magma' &&

.github/workflows/agw-workflow.yml

@@ -57,21 +57,21 @@ jobs:
     if: ${{ needs.path_filter.outputs.should_not_skip == 'true' }}
     runs-on: ubuntu-20.04
     steps:
-      - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # pin@v3.1.0
+      - uses: actions/checkout@v2 # pin@v0.18.1
       - name: Check clang-format for orc8r/gateway/c
-        uses: DoozyX/clang-format-lint-action@9ea72631b74e61ce337d0839a90e76180e997283 # pin@v0.13
+        uses: DoozyX/clang-format-lint-action@c71d0bf4e21876ebec3e5647491186f8797fde31 # pin@0.18.2
         with:
           source: 'orc8r/gateway/c'
           extensions: 'h,hpp,c,cpp'
-          clangFormatVersion: 11.1.0
+          clangFormatVersion: 18
           # taken from .clang-format
           style: file
       - name: Check clang-format for lte/gateway
-        uses: DoozyX/clang-format-lint-action@9ea72631b74e61ce337d0839a90e76180e997283 # pin@v0.13
+        uses: DoozyX/clang-format-lint-action@v0.18.1
         with:
           source: 'lte/gateway/c lte/gateway/python'
           extensions: 'h,hpp,c,cpp'
-          clangFormatVersion: 11.1.0
+          clangFormatVersion: 18
           # taken from .clang-format
           style: file
 

.github/workflows/bazel.yml

@@ -118,6 +118,7 @@ jobs:
 
             # Required for bazel-diff to perform git checkout.
             git config --global --add safe.directory /workspaces/magma
+            git config --global --add safe.directory /workspaces/magma/.git
 
             printf '\r%s\r' '###############################' 1>&2
             printf '\r%s\r' 'Bazel-diff.' 1>&2
@@ -330,13 +331,13 @@ jobs:
           mkdir -p lte/gateway/test_results/
           python3 lte/gateway/python/scripts/runtime_report.py -i "[^\/]+\.xml" -w "bazel_unit_test_results" -o "lte/gateway/test_results/merged_unit_test_reports.xml"
       - name: Publish bazel test profile
-        uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+        uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         if: ${{ always() && github.event.inputs.publish_bazel_profile == 'true' }}
         with:
           name: Bazel test all profile ${{ matrix.bazel-config }}
           path: Bazel_test_all_profile
       - name: Upload Bazel unit-test results ${{ matrix.bazel-config }}
-        uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+        uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         if: always()
         with:
           name: Bazel unit-test results ${{ matrix.bazel-config }}
@@ -590,7 +591,7 @@ jobs:
             mv ./bazel-bin/lte/gateway/c/session_manager/sessiond ./sentry_services/sessiond
 
       - name: Upload services for sentry_release job
-        uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+        uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         if: |
           github.repository_owner == 'magma' &&
           ( github.ref_name == 'master' || startsWith(github.ref_name, 'v1.') )
@@ -662,7 +663,7 @@ jobs:
           COMMIT_MESSAGE: ${{ toJSON(github.event.head_commit.message) }}
 
       - name: Publish bazel profile
-        uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+        uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         if: |
           always() &&
           github.event.inputs.publish_bazel_profile == 'true'
@@ -701,7 +702,7 @@ jobs:
         with:
           fetch-depth: 0
       - run: mkdir sentry_services
-      - uses: actions/download-artifact@9782bd6a9848b53b110e712e20e42d89988822b7 # pin@v3.0.1
+      - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # pin@v4
         with:
           name: sentry_services
           path: sentry_services

.github/workflows/build_all.yml

@@ -60,7 +60,7 @@ jobs:
             orc8r/tools/helm/package.sh --deployment-type all
           fi
       - name: Upload charts as artifacts
-        uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+        uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         if: github.event_name == 'pull_request'
         with:
           name: helm-charts
@@ -72,9 +72,9 @@ jobs:
           mkdir -p ./pr
           echo ${{ github.event.number }} > ./pr/pr_number
           echo "false" > ./pr/skipped
-      - uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+      - uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         with:
-          name: pr
+          name: jobs pr
           path: pr/
       # Notify ci channel when failing
       # Plugin info: https://github.com/marketplace/actions/slack-notify
@@ -260,9 +260,9 @@ jobs:
         run: |
           mkdir -p ./pr
           echo ${{ github.event.number }} > ./pr/pr_number
-      - uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+      - uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         with:
-          name: pr
+          name: deploy pr
           path: pr/
       - name: Create release Tag
         if: github.event_name == 'push'
@@ -331,9 +331,9 @@ jobs:
         run: |
           mkdir -p ./pr
           echo ${{ github.event.number }} > ./pr/pr_number
-      - uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+      - uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         with:
-          name: pr
+          name: operator pr
           path: pr/
       - name: Create release Tag
         if: github.event_name == 'push'

.github/workflows/cloud-workflow.yml

@@ -57,7 +57,7 @@ jobs:
         run: |
           mkdir -p ./pr
           echo -n ${{ steps.changes.outputs.filesChanged == 'false' }} > ./pr/skipped
-      - uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+      - uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         if: always()
         with:
           name: pr
@@ -111,15 +111,15 @@ jobs:
         timeout-minutes: 15
       - name: Upload Test Results
         if: always()
-        uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+        uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         with:
           name: Unit Test Results
           path: "${{ env.MAGMA_ROOT}}/orc8r/cloud/test-results/*"
       - uses: actions/setup-go@c4a742cab115ed795e34d4513e2cf7d472deb55f # pin@v3.3.1
         if: always()
         id: gateway_test_init
         with:
-          go-version: '1.20.1'
+          go-version: '1.21.12'
       - name: Download dependencies
         if: always() && steps.gateway_test_init.outcome=='success'
         id: gateway_test_dep

.github/workflows/composite/dp-integ-tests/action.yml

@@ -76,7 +76,7 @@ runs:
 
     - name: Upload integration test results
       if: always()
-      uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+      uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
       with:
         name: ${{ inputs.make_tests_target }}-results
         path: ${{ inputs.test_dir }}

.github/workflows/cwf-integ-test.yml

@@ -44,7 +44,7 @@ jobs:
           docker save cwf_cwag_go:latest  | gzip > cwf_cwag_go.tar.gz
           docker save cwf_gateway_go:latest | gzip > cwf_gateway_go.tar.gz
           docker save cwf_gateway_pipelined:latest | gzip > cwf_gateway_pipelined.tar.gz
-      - uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+      - uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         with:
           name: docker-images
           path: images
@@ -107,7 +107,7 @@ jobs:
           pip3 install --upgrade pip
           pip3 install ansible fabric jsonpickle requests PyYAML firebase_admin
           sudo apt install virtualbox
-      - uses: actions/download-artifact@9782bd6a9848b53b110e712e20e42d89988822b7 # pin@v3.0.1
+      - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # pin@v4
         with:
           name: docker-images
       - uses: geekyeggo/delete-artifact@54ab544f12cdb7b71613a16a2b5a37a9ade990af # pin@v2.0.0
@@ -134,7 +134,7 @@ jobs:
           fab integ-test --destroy-vm --transfer-images --test-result-xml=tests.xml --rerun-fails=3 --skip-docker-load --tar-path="/tmp/cwf-images"
       - name: Upload test results
         if: always()
-        uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+        uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         with:
           name: test-results
           path: cwf/gateway/tests.xml
@@ -154,7 +154,7 @@ jobs:
           cp *.log logs/
       - name: Upload logs
         if: always()
-        uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+        uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         with:
           name: test-logs
           path: cwf/gateway/logs

.github/workflows/dco-check.yml

@@ -49,10 +49,10 @@ jobs:
           mkdir -p ./pr
           echo -n ${{ steps.reverted_pr_check.outputs.is_reverted_pr }} > ./pr/is_reverted_pr
           echo -n "false" > ./pr/skipped
-      - uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+      - uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         if: always()
         with:
-          name: pr
+          name: reverted check pr
           path: pr/
 
   dco_check_job:
@@ -66,7 +66,7 @@ jobs:
         uses: tim-actions/get-pr-commits@c64db31d359214d244884dd68f971a110b29ab83 # pin@master
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
-      - name: DCO Check
+      - name: Perform DCO Check
         uses: tim-actions/dco@f2279e6e62d5a7d9115b0cb8e837b777b1b02e21 # pin@master
         with:
           commits: ${{ steps.get-pr-commits.outputs.commits }}
@@ -76,8 +76,8 @@ jobs:
         run: |
           mkdir -p ./pr
           echo -n ${{ github.event.number }} > ./pr/pr_number
-      - uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+      - uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         if: always()
         with:
-          name: pr
+          name: dco check job pr
           path: pr/

.github/workflows/docs-workflow.yml

@@ -52,7 +52,7 @@ jobs:
           echo -n ${{ github.event.number }} > ./pr/pr_number
           echo -n ${{ steps.changes.outputs.filesChanged == 'false' }} > ./pr/skipped
           echo -n "false" > ./pr/is_reverted_pr
-      - uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # pin@v3
+      - uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # pin@v4
         if: always()
         with:
           name: pr