Skip to content

Increase output buffer size for float to string conversion #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PhilipDeegan wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Increase output buffer size for float to string conversion #1429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/fptostring.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ std::string FpToString(T v, int precision = 0) {

// Case 1 - scientific notation: max digits of size_t plus sign, a dot and 2 letters for 'e+' or 'e-' and 4 letters for the exponent
// Case 2 - default notation: require up to precision number of digits and one for a potential sign
std::array<char, 28> output_buffer;
std::array<char, 32> output_buffer;
auto output_ptr = &output_buffer[0];

// Helper variable that in Case 2 counts the overflowing number of zeros that do not fit into the buffer.
Expand Down
Loading