Skip to content

[cmake] Require CMake 3.15 or newer#1358

Draft
gruenich wants to merge 3 commits intojbeder:masterfrom
gruenich:feature/cmake-require-3.15
Draft

[cmake] Require CMake 3.15 or newer#1358
gruenich wants to merge 3 commits intojbeder:masterfrom
gruenich:feature/cmake-require-3.15

Conversation

@gruenich
Copy link
Copy Markdown
Contributor

@gruenich gruenich commented Apr 29, 2025

  • The currently used version of Google-test 1.13 still triggers a CMake deprecation warning with CMake 3.30 or newer. We need to decide on which version of Google-test we want to update. I see no reason to not choose the most recent version 1.16 which requires C++14 (like Google-test 1.13) and CMake 3.13. (I went for Google-test 1.16)
  • Adjust CI to test for both CMake 3.15 and 4.0, the new min and max required version.

@henryiii
Copy link
Copy Markdown

For context, googletest does not specify a range, which is why the minimum matters there.

@gruenich gruenich force-pushed the feature/cmake-require-3.15 branch from bcaca6d to 35ad556 Compare May 1, 2025 17:21
@gruenich
Copy link
Copy Markdown
Contributor Author

gruenich commented May 1, 2025

@henryiii How did you image testing with distinct versions of CMake? Downloading and building CMake from source seems excessive.

@henryiii
Copy link
Copy Markdown

henryiii commented May 1, 2025

I do it in pybind11 and CLI11 (local support action). Basically jwlawson/actions-setup-cmake downloads binaries pretty quickly.

@gruenich gruenich force-pushed the feature/cmake-require-3.15 branch 2 times, most recently from 670585e to f698b0c Compare April 12, 2026 15:52
Ensure that oldest supportest version of CMake can configure project
Copy quick_cmake from CLIUtils/CLI11
@gruenich gruenich force-pushed the feature/cmake-require-3.15 branch from f698b0c to 4e3c06b Compare April 12, 2026 16:06
@gruenich
Copy link
Copy Markdown
Contributor Author

I removed a maximum version, just requiring 3.15 seems the saner choice for now.

Two points are left:

  1. Are you okay with relicensing the quick_cmake action from CLI?
  2. The Action is not reported as a success. Not sure what I missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants