Add configurable panningmodel property to positional sounds - #322
Open
jbaicoianu wants to merge 1 commit into
Open
Add configurable panningmodel property to positional sounds#322jbaicoianu wants to merge 1 commit into
jbaicoianu wants to merge 1 commit into
Conversation
Positional sounds hard-coded panningModel = 'HRTF'. Expose it as a `panningmodel` property (default 'HRTF', so existing behavior is unchanged) and apply it both on creation and on live update, so an individual sound — e.g. a center/dialogue virtual speaker — can opt into 'equalpower' panning and avoid HRTF's presence-band coloration. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Positional sounds hard-coded
panner.panningModel = 'HRTF'. This exposes it as apanningmodelproperty (default'HRTF') and applies it both at creation and on live update.Why
Part of fixing muddy virtual-speaker surround output. When every channel of a 5.1 mix is fed through an HRTF panner, the center/dialogue channel picks up HRTF's direction-dependent notches in the 2–5 kHz speech-presence band and smears against the other correlated feeds. Being able to set a center virtual speaker to
equalpowerkeeps dialogue crisp while the surrounds keep HRTF for 3D placement.Safety
Default is
'HRTF', so every existing sound is behaviorally unchanged — only a sound that explicitly opts into another model changes.Related
Enables the surround bass-management / center-clarity work in
janus-custom-components(companion PR), whosespeakerelement setspanningmodel: 'equalpower'on the center channel.🤖 Generated with Claude Code