Repository navigation
fix(web): only top-level chats notify - #243
Merged
Merged
Conversation
Child chats, delegated tasks, side chats and subagents no longer play sounds, show OS notifications or toasts, or add to the badge. Only threads with no parent of any kind notify; a child's question or approval already wakes its parent, which asks the user when it needs them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Desktop and web notifications (sound, OS notification, in-app toast, badge) fired for listed child chats, such as
t3_thread_launch/create_threadschildren, named-agentdelegate_taskchildren, and tasks delegated in from linked environments. A captain running a fleet beeped on every child that finished or asked something.Fix
hasParentThreadinpackages/client-runtime/src/state/threadShell.ts. It is true for a child, a subagent, a side chat, or any thread withdelegatedFrom.ThreadNotificationCoordinator.observeThreadsnow skips onhasParentThreadin place ofisShownUnderParent. The coordinator no longer needsdelegatedUnderParentAtomor its subscription.Nothing is lost. The server's
DelegatedTaskQuestionReactorwakes a local child's direct parent for both questions and approvals, so the parent asks the user when it needs them, and the root then notifies. Subagent and side-chat requests still roll up to the parent throughpendingSubagentRequests.Proof
New case in
ThreadNotificationCoordinator.badge.browser.test.ts: a root, a listed child and a delegated-in task each ask for input, then each complete.main: 6 notifications, including Child and Delegated.Input needed: RootandThread completed: Root, with a badge of 1.vp run check:changedpasses.No visual change, so there are no captures.
Merge risk
Low and client-only. If a delegated-in task's parent environment is not connected to this client, that task no longer notifies on its own. That was the intent.
Opus 5.5 · Claude Code
🤖 Generated with Claude Code