Repository navigation
fix(mobile): clearer schedule editor copy and one time zone style - #232
Merged
Merged
Conversation
The schedule type row is "Type", next runs within the week read "Next run Monday at …", and the editor's Time row names the zone the same way as the list (GMT+7, PST) on web and mobile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
The editor's guardBack hid the system Back button behind a custom one and turned off swipe-back. With the system back item gone, UIKit stops the edge swipe before react-native-screens can report it as a prevented dismiss, so swiping did nothing and the Discard changes dialog never appeared. The V5 stack already blocks native dismissal for routes guarded by usePreventRemove and routes the attempt to goBack, which raises the guard's dialog. Remove guardBack so system Back and swipe both go through that path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up copy fixes from the #227 captures. The editor-exit bug (item 1) is not fixed here; see below.
scheduleTimeZoneLabelnow always uses the short name, at the run time when there is one and now otherwise. Web and mobile both call it, so the editor and the list agree on both clients.Not in this PR: the editor can't be left with unsaved changes
I couldn't find the cause by reading the code, and there's no iOS Simulator on this machine to test against, so I haven't shipped a guess. What I checked:
goBack()emitsbeforeRemoveon the editor route,usePreventRemovecallspreventDefault()and then the callback, and the callback callsDialog.alert, which is nativeAlert.alert.beforeRemovelistener orusePreventRemovesits on that route.headerBackVisible: false, and the guarded Back bar button callsnavigation.goBack().The only thing this editor does differently from the two other screens that guard removal (
ThreadFilesRouteScreen,ZipArchiveView) isguardBack. That hides native Back, adds a JS bar button, and setsgestureEnabled: false. With the gesture off, an edge swipe can never ask anything. The iOS card stack already blocks a native dismiss for a prevented route and callsgoBack()inonNativeDismissPrevented. So droppingguardBackfor this screen is the first experiment to try on a device.Verification
scheduledTaskTimeZone.test.ts: the updated assertion (generic name → short name) failed first, then passed. The web settings logic and browser tests and the mobile draft tests pass: 68 tests.vp run check:changedpasses all steps.Captures still needed, from the MacBook at 390pt, light and dark:
Implemented by Claude Opus 5.5 in Claude Code (T3 Code).
🤖 Generated with Claude Code