Fix race condition in logOut. Fixes #1004#1038
Open
chr15m wants to merge 1 commit intojaredhanson:masterfrom
Open
Fix race condition in logOut. Fixes #1004#1038chr15m wants to merge 1 commit intojaredhanson:masterfrom
chr15m wants to merge 1 commit intojaredhanson:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update: I botched the previous PR so I'm re-issuing this one.
This fixes a race condition where the session is saved but then modified again in the
keepSessionInfobranch and the callback is called before save is called again. This patch issues a second save in thekeepSessionInfoeliminating the race condition. Fixes #1004.Checklist
$ make test) executes successfully.I have left the following unchecked with an explanation:
$ make lint) executes successfully.When I ran
make lintI encountered an error becausejshintis expected on the path (as opposed to being installed by npm and being called withnpxfor example). When I added it to the path it threw several errors but none of them were related to this patch. These errors are all from the existing codebase. Maybe I have run this in error somehow or I'm missing a config file.I can't see how to replicate the failing condition in the current tests. I'm looking at
request.test.jsand I'm unsure how to simulate a backend which takes a while to set the values. Any guidance here welcome.I do not think any documentation changes will be necessary for this under-the-hood fix which will be transparent to the user.