fix: J10 paper-cuts — upload cap, setup slash, shebang, copy, auth guard, error swap - #69
Merged
Merged
Conversation
…, not trigger time)
The error() view passed render_template kwargs crossed (error_message=error_title, error=error_message), so the branded page showed the title as the body and the message as the h1. Now aligned with how error.html and _error_page use them: error = title, error_message = body. Test asserts each lands in its correct element (has teeth: fails if the swap returns).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The J10 paper-cuts batch (internal ref J10) — six small, individually-reviewed fixes. Full suite green (102 passed), ruff clean.
Fixes
MAX_CONTENT_LENGTH+client_max_body_size 16min JAWA's nginx vhost (both installer server blocks). Fixes the opaque failure when uploads hit nginx's silent 1 MB default.main(main is production forbin/installer.sh)./setuptrailing-slash strip —address/jss-lock/alternateare stripped before saving, so Jamf webhook URLs no longer get double slashes.#!are rejected at upload with a friendly error, instead of failing cryptically at trigger time (the receiver execs the file directly)./errorroute — no longer swaps the title and message when rendering the branded error page.Notes
developfor the batched v3.2 release.